'Re: Review Request 118073: Use QHostInfo in kio_nfs'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118073: Use QHostInfo in kio_nfs
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-05-29 15:06:02
Message-ID: 20140529150602.2659.51556 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118073/#review58735
-----------------------------------------------------------

Ship it!

nfs/kio_nfs.cpp
<https://git.reviewboard.kde.org/r/118073/#comment40860>

    I don't think so.

    Read qhostinfo_unix.cpp localDomainName

    it has all sorts of fallbacks.

- David Edmundson

On May 10, 2014, 2:42 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118073/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 2:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Use QHostInfo in kio_nfs
> 
> 
> Diffs
> -----
> 
>   nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 
>   nfs/kio_nfs.cpp 293df2529a2488b7970dbe81a5ec202bc6a22742 
> 
> Diff: https://git.reviewboard.kde.org/r/118073/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118073/">https://git.reviewboard.kde.org/r/118073/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/118073/diff/1/?file=272333#file272333line406" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nfs/kio_nfs.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
NFSProtocol::openConnection()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">406</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">   <span \
class="n">nameBuffer</span><span class="p">[</span><span class="mi">0</span><span \
class="p">]</span> <span class="o">=</span> <span class="sc">&#39;\0&#39;</span><span \
class="p">;</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">369</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">   <span class="c1">//</span><span \
class="cs">TODO</span><span class="c1">: is this comment still \
relevant?</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don&#39;t \
think so.

Read qhostinfo_unix.cpp localDomainName

it has all sorts of fallbacks.</pre>
</div>
<br />

<p>- David Edmundson</p>

<br />
<p>On May 10th, 2014, 2:42 p.m. UTC, Alexander Richardson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Alexander Richardson.</div>

<p style="color: grey;"><i>Updated May 10, 2014, 2:42 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use QHostInfo in kio_nfs</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>nfs/CMakeLists.txt <span style="color: \
grey">(dfc6eae3fad51eee0e736970da9520959eeed1f5)</span></li>

 <li>nfs/kio_nfs.cpp <span style="color: \
grey">(293df2529a2488b7970dbe81a5ec202bc6a22742)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118073/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 