--===============0654937118756129138== Content-Type: multipart/alternative; boundary="===============0314137817405426859==" --===============0314137817405426859== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118073/#review58735 ----------------------------------------------------------- Ship it! nfs/kio_nfs.cpp I don't think so. Read qhostinfo_unix.cpp localDomainName it has all sorts of fallbacks. - David Edmundson On May 10, 2014, 2:42 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118073/ > ----------------------------------------------------------- > > (Updated May 10, 2014, 2:42 p.m.) > > > Review request for Plasma. > > > Repository: kio-extras > > > Description > ------- > > Use QHostInfo in kio_nfs > > > Diffs > ----- > > nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 > nfs/kio_nfs.cpp 293df2529a2488b7970dbe81a5ec202bc6a22742 > > Diff: https://git.reviewboard.kde.org/r/118073/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Richardson > > --===============0314137817405426859== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118073/

Ship it!

nfs/kio_nfs.cpp (Diff revision 1) 
void NFSProtocol::openConnection()
406 
   nameBuffer[0] = '\0';
 369 
   //TODO: is this comment still relevant?
 
I don't think so.

Read qhostinfo_unix.cpp localDomainName

it has all sorts of fallbacks.

- David Edmundson


On May 10th, 2014, 2:42 p.m. UTC, Alexander Richardson wrote:

Review request for Plasma.
By Alexander Richardson.

Updated May 10, 2014, 2:42 p.m.

Repository: kio-extras

Description 

Use QHostInfo in kio_nfs

Diffs

  • nfs/CMakeLists.txt (dfc6eae3fad51eee0e736970da9520959eeed1f5)
  • nfs/kio_nfs.cpp (293df2529a2488b7970dbe81a5ec202bc6a22742)

View Diff
--===============0314137817405426859==-- --===============0654937118756129138== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0654937118756129138==--