[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118361: Don't hide Dialog when opening QMenu from it
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2014-05-28 9:19:07
Message-ID: 20140528091907.27844.15424 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 27, 2014, 10:36 p.m., Kai Uwe Broulik wrote:
> > src/plasmaquick/dialog.cpp, line 800
> > <https://git.reviewboard.kde.org/r/118361/diff/1/?file=275561#file275561line800>
> >
> > Isn't comparison more efficient using QLatin1String?
Last time I've heard it's not anymore in Qt5 thanks to QStringLiteral...is it still?
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/#review58609
-----------------------------------------------------------
On May 27, 2014, 9:13 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118361/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 9:13 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> When plasmoid in a popup is opening a QMenu, the popup itself hides because it \
> looses focus. This patch fixes it.
>
> Diffs
> -----
>
> src/plasmaquick/dialog.cpp d8e263c
>
> Diff: https://git.reviewboard.kde.org/r/118361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118361/">https://git.reviewboard.kde.org/r/118361/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 27th, 2014, 10:36 p.m. CEST, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118361/diff/1/?file=275561#file275561line800" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasmaquick/dialog.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Dialog::focusOutEvent(QFocusEvent *ev)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">800</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="n">childHasFocus</span> <span class="o">=</span> \
<span class="p"><span class="hl">(</span></span><span class="n">focusWindow</span> \
<span class="o">&&</span> <span class="n">focusWindow</span><span \
class="o">-></span><span class="n">isActive</span><span class="p">()</span> <span \
class="o">&&</span> <span class="n">isAncestorOf</span><span \
class="p">(</span><span class="n">focusWindow</span><span \
class="p">));</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">800</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span \
class="n">childHasFocus</span> <span class="o">=</span> <span \
class="n">focusWindow</span> <span class="o">&&</span> <span class="p"><span \
class="hl">((</span></span><span class="n">focusWindow</span><span \
class="o">-></span><span class="n">isActive</span><span class="p">()</span> <span \
class="o">&&</span> <span class="n">isAncestorOf</span><span \
class="p">(</span><span class="n">focusWindow</span><span class="p">))</span><span \
class="hl"> </span><span class="o"><span class="hl">||</span></span><span class="hl"> \
</span><span class="n"><span class="hl">focusWindow</span></span><span \
class="o"><span class="hl">-></span></span><span class="n"><span \
class="hl">objectName</span></span><span class="p"><span \
class="hl">()</span></span><span class="hl"> </span><span class="o"><span \
class="hl">==</span></span><span class="hl "> </span><span class="n"><span \
class="hl">QStringLiteral</span></span><span class="p"><span \
class="hl">(</span></span><span class="s"><span \
class="hl">"QMenuClassWindow"</span></span><span class="p"><span \
class="hl">))</span>;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't comparison \
more efficient using QLatin1String?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Last time \
I've heard it's not anymore in Qt5 thanks to QStringLiteral...is it \
still?</pre> <br />
<p>- Martin</p>
<br />
<p>On May 27th, 2014, 9:13 p.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 27, 2014, 9:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When plasmoid in a popup is opening a QMenu, the popup itself hides \
because it looses focus. This patch fixes it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(d8e263c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118361/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic