[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117954: Port keditfiletype away from kde4support
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2014-05-28 8:55:52
Message-ID: 20140528085552.27844.65948 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117954/
-----------------------------------------------------------
(Updated May 28, 2014, 8:55 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and David Faure.
Repository: kde-cli-tools
Description
-------
This patch contains multiple commits, which I can make available if needed. It ports \
keditfiletype away from kde4support, which helps identifying its dependencies so that \
it can hopefully be moved closer to the classes which need it in frameworks (right \
now kwidgetsaddons and kio forks it)
Diffs
-----
CMakeLists.txt d62ee8b
keditfiletype/CMakeLists.txt 566e76a
keditfiletype/filegroupdetails.cpp c733ba4
keditfiletype/filetypedetails.h 7c0abb4
keditfiletype/filetypedetails.cpp bfcbb07
keditfiletype/filetypesview.h 82fd0ab
keditfiletype/filetypesview.cpp 886892f
keditfiletype/keditfiletype.h 0b235ce
keditfiletype/keditfiletype.cpp aab0830
keditfiletype/kservicelistwidget.h c817d24
keditfiletype/kservicelistwidget.cpp 88dface
keditfiletype/kserviceselectdlg.h 8e6d0d0
keditfiletype/kserviceselectdlg.cpp 09c7c5d
keditfiletype/mimetypedata.h 042b043
keditfiletype/mimetypedata.cpp 057113f
keditfiletype/mimetypewriter.h 5a618a6
keditfiletype/mimetypewriter.cpp be5e5d4
keditfiletype/newtypedlg.h fba8385
keditfiletype/newtypedlg.cpp c933a8f
keditfiletype/sharedmimeinfoversion.h 9824d7b
keditfiletype/sharedmimeinfoversion.cpp 9dabf0e
keditfiletype/tests/CMakeLists.txt 489bb4d
keditfiletype/tests/filetypestest.cpp 68eef26
keditfiletype/typeslistitem.h 05e425a
keditfiletype/typeslistitem.cpp 97cd3c1
Diff: https://git.reviewboard.kde.org/r/117954/diff/
Testing
-------
Program starts and looks like it behaves correctly. Unit-test is failing, but was \
already failing before :/
Thanks,
Aurélien Gâteau
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117954/">https://git.reviewboard.kde.org/r/117954/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and David Faure.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 8:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-cli-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch contains multiple commits, which I can make available if \
needed. It ports keditfiletype away from kde4support, which helps identifying its \
dependencies so that it can hopefully be moved closer to the classes which need it in \
frameworks (right now kwidgetsaddons and kio forks it)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Program starts and looks like it behaves correctly. Unit-test is \
failing, but was already failing before :/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d62ee8b)</span></li>
<li>keditfiletype/CMakeLists.txt <span style="color: grey">(566e76a)</span></li>
<li>keditfiletype/filegroupdetails.cpp <span style="color: \
grey">(c733ba4)</span></li>
<li>keditfiletype/filetypedetails.h <span style="color: grey">(7c0abb4)</span></li>
<li>keditfiletype/filetypedetails.cpp <span style="color: \
grey">(bfcbb07)</span></li>
<li>keditfiletype/filetypesview.h <span style="color: grey">(82fd0ab)</span></li>
<li>keditfiletype/filetypesview.cpp <span style="color: grey">(886892f)</span></li>
<li>keditfiletype/keditfiletype.h <span style="color: grey">(0b235ce)</span></li>
<li>keditfiletype/keditfiletype.cpp <span style="color: grey">(aab0830)</span></li>
<li>keditfiletype/kservicelistwidget.h <span style="color: \
grey">(c817d24)</span></li>
<li>keditfiletype/kservicelistwidget.cpp <span style="color: \
grey">(88dface)</span></li>
<li>keditfiletype/kserviceselectdlg.h <span style="color: \
grey">(8e6d0d0)</span></li>
<li>keditfiletype/kserviceselectdlg.cpp <span style="color: \
grey">(09c7c5d)</span></li>
<li>keditfiletype/mimetypedata.h <span style="color: grey">(042b043)</span></li>
<li>keditfiletype/mimetypedata.cpp <span style="color: grey">(057113f)</span></li>
<li>keditfiletype/mimetypewriter.h <span style="color: grey">(5a618a6)</span></li>
<li>keditfiletype/mimetypewriter.cpp <span style="color: grey">(be5e5d4)</span></li>
<li>keditfiletype/newtypedlg.h <span style="color: grey">(fba8385)</span></li>
<li>keditfiletype/newtypedlg.cpp <span style="color: grey">(c933a8f)</span></li>
<li>keditfiletype/sharedmimeinfoversion.h <span style="color: \
grey">(9824d7b)</span></li>
<li>keditfiletype/sharedmimeinfoversion.cpp <span style="color: \
grey">(9dabf0e)</span></li>
<li>keditfiletype/tests/CMakeLists.txt <span style="color: \
grey">(489bb4d)</span></li>
<li>keditfiletype/tests/filetypestest.cpp <span style="color: \
grey">(68eef26)</span></li>
<li>keditfiletype/typeslistitem.h <span style="color: grey">(05e425a)</span></li>
<li>keditfiletype/typeslistitem.cpp <span style="color: grey">(97cd3c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117954/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic