[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one
From: "Gregor Mi" <codeminister () publicstatic ! de>
Date: 2014-04-30 19:59:42
Message-ID: 20140430195942.1393.33138 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 30, 2014, 9:04 a.m., Marco Martin wrote:
> > The idea makes sense, however it's on Plasma1, that shouldn't have nev changes \
> > in. best thing would be to have this done directly in plasam2
Thanks for the affirmation. So I keep this request open until the the plasma2 version \
of the applet is created. Maybe by me or is there someone who has the \
ShowDashboard/Desktop applets on the agenda?
- Gregor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117802/#review56949
-----------------------------------------------------------
On April 30, 2014, 1:26 a.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117802/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 1:26 a.m.)
>
>
> Review request for Plasma, Aleix Pol Gonzalez and Dominik Haumann.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> This is a proposition to merge the plasma applets ShowDashboard and ShowDesktop \
> into one since both share the same basic logic. As a bonus users with large panels \
> have to option to have both functions stacked vertically so save space on an \
> horizontal panel.
> Detailed description see here: http://codestruct.jimdo.com/struct/showdeskboard/
> - shows a small screencast how it looks like when the container panel is resized
> - shows a table with screenshots that shows how different settings in the \
> configuration dialog look like on small and large panels.
> (This review request is based on https://git.reviewboard.kde.org/r/117681/)
>
>
> Diffs
> -----
>
> applets/showdesktop/CMakeLists.txt eb532075cbe8ff734bebdfc8d35af7e9e9f5c32d
> applets/showdesktop/showdesktop.h 5aeb8481df824f6ea9d7969cf544876f5fb3473c
> applets/showdesktop/showdesktop.cpp d712519918fcf2efe4dbbb5337a29316d53e759a
> applets/showdesktop/showdesktopConfig.ui PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/117802/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gregor Mi
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117802/">https://git.reviewboard.kde.org/r/117802/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 30th, 2014, 9:04 a.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The idea makes sense, however it's on Plasma1, that shouldn't \
have nev changes in. best thing would be to have this done directly in plasam2</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the \
affirmation. So I keep this request open until the the plasma2 version of the applet \
is created. Maybe by me or is there someone who has the ShowDashboard/Desktop applets \
on the agenda?</pre> <br />
<p>- Gregor</p>
<br />
<p>On April 30th, 2014, 1:26 a.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez and Dominik Haumann.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated April 30, 2014, 1:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a proposition to merge the plasma applets ShowDashboard and \
ShowDesktop into one since both share the same basic logic. As a bonus users with \
large panels have to option to have both functions stacked vertically so save space \
on an horizontal panel.
Detailed description see here: http://codestruct.jimdo.com/struct/showdeskboard/
- shows a small screencast how it looks like when the container panel is resized
- shows a table with screenshots that shows how different settings in the \
configuration dialog look like on small and large panels.
(This review request is based on https://git.reviewboard.kde.org/r/117681/)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/showdesktop/CMakeLists.txt <span style="color: \
grey">(eb532075cbe8ff734bebdfc8d35af7e9e9f5c32d)</span></li>
<li>applets/showdesktop/showdesktop.h <span style="color: \
grey">(5aeb8481df824f6ea9d7969cf544876f5fb3473c)</span></li>
<li>applets/showdesktop/showdesktop.cpp <span style="color: \
grey">(d712519918fcf2efe4dbbb5337a29316d53e759a)</span></li>
<li>applets/showdesktop/showdesktopConfig.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117802/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic