--===============5665250360654438304== Content-Type: multipart/alternative; boundary="===============8746819599203448813==" --===============8746819599203448813== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On April 30, 2014, 9:04 a.m., Marco Martin wrote: > > The idea makes sense, however it's on Plasma1, that shouldn't have nev changes in. > > best thing would be to have this done directly in plasam2 Thanks for the affirmation. So I keep this request open until the the plasma2 version of the applet is created. Maybe by me or is there someone who has the ShowDashboard/Desktop applets on the agenda? - Gregor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/#review56949 ----------------------------------------------------------- On April 30, 2014, 1:26 a.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117802/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 1:26 a.m.) > > > Review request for Plasma, Aleix Pol Gonzalez and Dominik Haumann. > > > Repository: kdeplasma-addons > > > Description > ------- > > This is a proposition to merge the plasma applets ShowDashboard and ShowDesktop into one since both share the same basic logic. As a bonus users with large panels have to option to have both functions stacked vertically so save space on an horizontal panel. > > Detailed description see here: http://codestruct.jimdo.com/struct/showdeskboard/ > - shows a small screencast how it looks like when the container panel is resized > - shows a table with screenshots that shows how different settings in the configuration dialog look like on small and large panels. > > (This review request is based on https://git.reviewboard.kde.org/r/117681/) > > > Diffs > ----- > > applets/showdesktop/CMakeLists.txt eb532075cbe8ff734bebdfc8d35af7e9e9f5c32d > applets/showdesktop/showdesktop.h 5aeb8481df824f6ea9d7969cf544876f5fb3473c > applets/showdesktop/showdesktop.cpp d712519918fcf2efe4dbbb5337a29316d53e759a > applets/showdesktop/showdesktopConfig.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117802/diff/ > > > Testing > ------- > > > Thanks, > > Gregor Mi > > --===============8746819599203448813== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/

On April 30th, 2014, 9:04 a.m. UTC, Marco Martin wrote:

The idea makes sense, however it's on Plasma1, that shouldn't have nev changes in.
best thing would be to have this done directly in plasam2

Thanks for the affirmation. So I keep this request open until the the plasma2 version of the applet is created. Maybe by me or is there someone who has the ShowDashboard/Desktop applets on the agenda?

- Gregor

On April 30th, 2014, 1:26 a.m. UTC, Gregor Mi wrote:

Review request for Plasma, Aleix Pol Gonzalez and Dominik Haumann.

By Gregor Mi.

Updated April 30, 2014, 1:26 a.m.

Repository: kdeplasma-addons

Description

This is a proposition to merge the plasma applets ShowDashboard and ShowDesktop into one since both share the same basic logic. As a bonus users with large panels have to option to have both functions stacked vertically so save space on an horizontal panel.

Detailed description see here: http://codestruct.jimdo.com/struct/showdeskboard/
- shows a small screencast how it looks like when the container panel is resized
- shows a table with screenshots that shows how different settings in the configuration dialog look like on small and large panels.

(This review request is based on https://git.reviewboard.kde.org/r/117681/)

Diffs

applets/showdesktop/CMakeLists.txt (eb532075cbe8ff734bebdfc8d35af7e9e9f5c32d)
applets/showdesktop/showdesktop.h (5aeb8481df824f6ea9d7969cf544876f5fb3473c)
applets/showdesktop/showdesktop.cpp (d712519918fcf2efe4dbbb5337a29316d53e759a)
applets/showdesktop/showdesktopConfig.ui (PRE-CREATION)

--===============8746819599203448813==-- --===============5665250360654438304== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5665250360654438304==--