'Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2014-04-30 9:27:02
Message-ID: 20140430092702.1393.97802 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On April 30, 2014, 12:56 a.m., Hrvoje Senjan wrote:
> > kuiserver/CMakeLists.txt, line 73
> > <https://git.reviewboard.kde.org/r/117876/diff/2/?file=269233#file269233line73>
> > 
> > i guess also org.kde.kuiserver.service would need adjusting ...
> 
> Marco Martin wrote:
> shouldn't the services maintain their name? i don't think we want co-runnability \
> no? (if changed everybody using them should be adapted, leading to things breaking \
> with no obvious reasons) 
> Jonathan Riddell wrote:
> The patch does rename org.kde.kuiserver.service.  
> 
> From http://www.freedesktop.org/wiki/IntroductionToDBus/  "write a service file \
> "bankcounter.service" (the name is arbitrary, so long as it ends with .service)"

i meant more the exec line in the service =)

- Hrvoje

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117876/#review56933
-----------------------------------------------------------

On April 30, 2014, 11:20 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117876/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with \
> plasma next.  rename to kuiserver5. 
> 
> Diffs
> -----
> 
> kuiserver/CMakeLists.txt 6d79b41 
> kuiserver/kuiserver.desktop 2dec197 
> 
> Diff: https://git.reviewboard.kde.org/r/117876/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117876/">https://git.reviewboard.kde.org/r/117876/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On April 30th, 2014, 12:56 a.m. CEST, <b>Hrvoje \
Senjan</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/117876/diff/2/?file=269233#file269233line73" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kuiserver/CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">73</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">target_link_libraries</span><span class="p">(</span> <span \
class="s">kuiserver</span> <span class="s">kdeinit_kuiserver</span> <span \
class="p">)</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">73</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span \
class="nb">target_link_libraries</span><span class="p">(</span> <span \
class="s">kuiserver<span class="hl">5</span></span> <span \
class="s">kdeinit_kuiserver</span> <span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i guess also \
org.kde.kuiserver.service would need adjusting ...</pre>  </blockquote>

 <p>On April 30th, 2014, 11 a.m. CEST, <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn&#39;t the \
services maintain their name? i don&#39;t think we want co-runnability no? (if \
changed everybody using them should be adapted, leading to things breaking with no \
obvious reasons)</pre>  </blockquote>

 <p>On April 30th, 2014, 11:21 a.m. CEST, <b>Jonathan Riddell</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch does rename \
org.kde.kuiserver.service.  

From http://www.freedesktop.org/wiki/IntroductionToDBus/  &quot;write a service file \
&quot;bankcounter.service&quot; (the name is arbitrary, so long as it ends with \
.service)&quot;</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i meant \
more the exec line in the service =)</pre> <br />

<p>- Hrvoje</p>

<br />
<p>On April 30th, 2014, 11:20 a.m. CEST, Jonathan Riddell wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>

<p style="color: grey;"><i>Updated April 30, 2014, 11:20 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kuiserver in kde 4 land is from kde-runtime so needs to be \
co-installable with plasma next.  rename to kuiserver5. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kuiserver/CMakeLists.txt <span style="color: grey">(6d79b41)</span></li>

 <li>kuiserver/kuiserver.desktop <span style="color: grey">(2dec197)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117876/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 