--===============2084717309694877867== Content-Type: multipart/alternative; boundary="===============0986046498065235106==" --===============0986046498065235106== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On April 30, 2014, 12:56 a.m., Hrvoje Senjan wrote: > > kuiserver/CMakeLists.txt, line 73 > > > > > > i guess also org.kde.kuiserver.service would need adjusting ... > > Marco Martin wrote: > shouldn't the services maintain their name? i don't think we want co-runnability no? (if changed everybody using them should be adapted, leading to things breaking with no obvious reasons) > > Jonathan Riddell wrote: > The patch does rename org.kde.kuiserver.service. > > From http://www.freedesktop.org/wiki/IntroductionToDBus/ "write a service file "bankcounter.service" (the name is arbitrary, so long as it ends with .service)" i meant more the exec line in the service =) - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/#review56933 ----------------------------------------------------------- On April 30, 2014, 11:20 a.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117876/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 11:20 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. > > > Diffs > ----- > > kuiserver/CMakeLists.txt 6d79b41 > kuiserver/kuiserver.desktop 2dec197 > > Diff: https://git.reviewboard.kde.org/r/117876/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > > --===============0986046498065235106== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/

On April 30th, 2014, 12:56 a.m. CEST, Hrvoje Senjan wrote:

kuiserver/CMakeLists.txt (Diff revision 2)
73	target_link_libraries( kuiserver kdeinit_kuiserver )	73	target_link_libraries( kuiserver5 kdeinit_kuiserver )

i guess also org.kde.kuiserver.service would need adjusting ...

On April 30th, 2014, 11 a.m. CEST, Marco Martin wrote:

shouldn't the services maintain their name? i don't think we want co-runnability no? (if changed everybody using them should be adapted, leading to things breaking with no obvious reasons)

On April 30th, 2014, 11:21 a.m. CEST, Jonathan Riddell wrote:

The patch does rename org.kde.kuiserver.service.  

From http://www.freedesktop.org/wiki/IntroductionToDBus/  "write a service file "bankcounter.service" (the name is arbitrary, so long as it ends with .service)"

i meant more the exec line in the service =)

- Hrvoje

On April 30th, 2014, 11:20 a.m. CEST, Jonathan Riddell wrote:

Review request for Plasma.

By Jonathan Riddell.

Updated April 30, 2014, 11:20 a.m.

Repository: plasma-workspace

Description

kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next.  rename to kuiserver5.

Diffs

kuiserver/CMakeLists.txt (6d79b41)
kuiserver/kuiserver.desktop (2dec197)

--===============0986046498065235106==-- --===============2084717309694877867== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2084717309694877867==--