'Re: Review Request 117450: Add Milou to the default panel layout'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117450: Add Milou to the default panel layout
From:       "Giorgos Tsiapaliokas" <giorgos.tsiapaliokas () Kde ! org>
Date:       2014-04-12 9:29:38
Message-ID: 20140412092938.22681.21646 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117450/#review55488
-----------------------------------------------------------

I would prefer if we didn't add milou to the panel by default, because 
a. IMO the panel will become over populated.
b. IMO the first thing the user will notice after an update in KDE is the panel.
   The user will see that there is a new plasmoid which didn't exist back in
   KDE4 by default. IIRC we had said that plasma next won't have any new big ui \
changes and  this one seems to me a big one. Considering that users will update from \
KDE4 to  the new major version, a changed panel may make plasma look "evil" again.

- Giorgos Tsiapaliokas

On April 9, 2014, 6:22 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117450/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 6:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> KRunner is hidden away as it is only accessible via a shortcut. It will be nice to \
> have the plasmoid visible by default. It will not be an extra dependency as \
> plasma-workspace already depends on Milou because of KRunner. 
> 
> Diffs
> -----
> 
> desktoppackage/contents/layout.js 303e7af 
> 
> Diff: https://git.reviewboard.kde.org/r/117450/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117450/">https://git.reviewboard.kde.org/r/117450/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would prefer if we \
didn&#39;t add milou to the panel by default, because  a. IMO the panel will become \
over populated. b. IMO the first thing the user will notice after an update in KDE is \
the panel.  The user will see that there is a new plasmoid which didn&#39;t exist \
back in  KDE4 by default. IIRC we had said that plasma next won&#39;t have any new \
big ui changes and  this one seems to me a big one. Considering that users will \
update from KDE4 to  the new major version, a changed panel may make plasma look \
&quot;evil&quot; again.</pre>  <br />

<p>- Giorgos Tsiapaliokas</p>

<br />
<p>On April 9th, 2014, 6:22 p.m. EEST, Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated April 9, 2014, 6:22 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KRunner is hidden away as it is only accessible via a shortcut. It will \
be nice to have the plasmoid visible by default. It will not be an extra dependency \
as plasma-workspace already depends on Milou because of KRunner.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/layout.js <span style="color: \
grey">(303e7af)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117450/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 