[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor
From: "Commit Hook" <null () kde ! org>
Date: 2014-03-27 20:44:39
Message-ID: 20140327204439.3055.14027 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/#review54375
-----------------------------------------------------------
This review has been submitted with commit 9d7fb9c1efa1228c3a8ddcd6ed2a28424f6dbe8a \
by Ashish Madeti to branch sujith-dbus-mpris.
- Commit Hook
On March 27, 2014, 8:33 p.m., Ashish Madeti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116907/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 8:33 p.m.)
>
>
> Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu \
> Tushar, Sinny Kumari, and Sujith Haridasan.
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Implemented "Player" DBus adaptor of MPRIS specifications for Plasma Mediacenter.
> Specification reference: \
> http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
> Some more work needs to be done in the adaptor which I plan to do soon.
>
>
> Diffs
> -----
>
> libs/mpris2/mediaplayer2.h e68bc5c
> libs/mpris2/mediaplayer2.cpp ff96618
> libs/mpris2/mediaplayer2player.h 203d681
> libs/mpris2/mediaplayer2player.cpp 7871efa
> libs/mpris2/mpris2.cpp a8ad3ef
> mediaelements/mediaplayer/MediaPlayer.qml 39ed617
> shells/newshell/mainwindow.cpp d2d71d4
> shells/newshell/package/contents/ui/mediacenter.qml bac33c2
>
> Diff: https://git.reviewboard.kde.org/r/116907/diff/
>
>
> Testing
> -------
>
> Tested with qdbusviewer, the properties and methods are working fine.
>
>
> Thanks,
>
> Ashish Madeti
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116907/">https://git.reviewboard.kde.org/r/116907/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 9d7fb9c1efa1228c3a8ddcd6ed2a28424f6dbe8a by Ashish Madeti to \
branch sujith-dbus-mpris.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On March 27th, 2014, 8:33 p.m. UTC, Ashish Madeti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu \
Tushar, Sinny Kumari, and Sujith Haridasan.</div> <div>By Ashish Madeti.</div>
<p style="color: grey;"><i>Updated March 27, 2014, 8:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implemented "Player" DBus adaptor of MPRIS specifications for \
Plasma Mediacenter. Specification reference: \
http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
Some more work needs to be done in the adaptor which I plan to do soon.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with qdbusviewer, the properties and methods are working \
fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mpris2/mediaplayer2.h <span style="color: grey">(e68bc5c)</span></li>
<li>libs/mpris2/mediaplayer2.cpp <span style="color: grey">(ff96618)</span></li>
<li>libs/mpris2/mediaplayer2player.h <span style="color: grey">(203d681)</span></li>
<li>libs/mpris2/mediaplayer2player.cpp <span style="color: \
grey">(7871efa)</span></li>
<li>libs/mpris2/mpris2.cpp <span style="color: grey">(a8ad3ef)</span></li>
<li>mediaelements/mediaplayer/MediaPlayer.qml <span style="color: \
grey">(39ed617)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(d2d71d4)</span></li>
<li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(bac33c2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116907/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic