--===============5709421344649198359== Content-Type: multipart/alternative; boundary="===============4391255782969896894==" --===============4391255782969896894== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54375 ----------------------------------------------------------- This review has been submitted with commit 9d7fb9c1efa1228c3a8ddcd6ed2a28424f6dbe8a by Ashish Madeti to branch sujith-dbus-mpris. - Commit Hook On March 27, 2014, 8:33 p.m., Ashish Madeti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116907/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 8:33 p.m.) > > > Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Implemented "Player" DBus adaptor of MPRIS specifications for Plasma Mediacenter. > Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html > > Some more work needs to be done in the adaptor which I plan to do soon. > > > Diffs > ----- > > libs/mpris2/mediaplayer2.h e68bc5c > libs/mpris2/mediaplayer2.cpp ff96618 > libs/mpris2/mediaplayer2player.h 203d681 > libs/mpris2/mediaplayer2player.cpp 7871efa > libs/mpris2/mpris2.cpp a8ad3ef > mediaelements/mediaplayer/MediaPlayer.qml 39ed617 > shells/newshell/mainwindow.cpp d2d71d4 > shells/newshell/package/contents/ui/mediacenter.qml bac33c2 > > Diff: https://git.reviewboard.kde.org/r/116907/diff/ > > > Testing > ------- > > Tested with qdbusviewer, the properties and methods are working fine. > > > Thanks, > > Ashish Madeti > > --===============4391255782969896894== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ 

This review has been submitted with commit 9d7fb9c1efa1228c3a8ddcd6ed2a28424f6dbe8a by Ashish Madeti to branch sujith-dbus-mpris.

- Commit Hook


On March 27th, 2014, 8:33 p.m. UTC, Ashish Madeti wrote:

Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
By Ashish Madeti.

Updated March 27, 2014, 8:33 p.m.

Repository: plasma-mediacenter

Description 

Implemented "Player" DBus adaptor of MPRIS specifications for Plasma Mediacenter.
Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html

Some more work needs to be done in the adaptor which I plan to do soon.

Testing 

Tested with qdbusviewer, the properties and methods are working fine.

Diffs

  • libs/mpris2/mediaplayer2.h (e68bc5c)
  • libs/mpris2/mediaplayer2.cpp (ff96618)
  • libs/mpris2/mediaplayer2player.h (203d681)
  • libs/mpris2/mediaplayer2player.cpp (7871efa)
  • libs/mpris2/mpris2.cpp (a8ad3ef)
  • mediaelements/mediaplayer/MediaPlayer.qml (39ed617)
  • shells/newshell/mainwindow.cpp (d2d71d4)
  • shells/newshell/package/contents/ui/mediacenter.qml (bac33c2)

View Diff
--===============4391255782969896894==-- --===============5709421344649198359== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5709421344649198359==--