'Review Request 116117: Place new panels to bottom by default'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 116117: Place new panels to bottom by default
From:       "Jan Grulich" <jgrulich () redhat ! com>
Date:       2014-02-27 14:07:12
Message-ID: 20140227140712.20354.68867 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116117/
-----------------------------------------------------------

Review request for kde-workspace and Plasma.

Repository: kde-workspace

Description
-------

When adding a new empty panel, it's placed at top by default, but it should be placed \
to bottom, when it's possible. Also when adding a new "Default Panel" to second \
screen without any panel and you already have one on your first screen, then it's \
also placed to top instead of bottom. This is just a simple fix, which changes order \
of checking free edges for empty panels and adds a check for screenId when executing \
a script for default panel layout. I'm not much sure with the javascript part, but it \
works.

Diffs
-----

  plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js \
47f635c   plasma/desktop/shell/desktopcorona.cpp d3635d9 

Diff: https://git.reviewboard.kde.org/r/116117/diff/

Testing
-------

Thanks,

Jan Grulich

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116117/">https://git.reviewboard.kde.org/r/116117/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace and Plasma.</div>
<div>By Jan Grulich.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When adding a new empty panel, it&#39;s placed at top by default, but it \
should be placed to bottom, when it&#39;s possible. Also when adding a new \
&quot;Default Panel&quot; to second screen without any panel and you already have one \
on your first screen, then it&#39;s also placed to top instead of bottom. This is \
just a simple fix, which changes order of checking free edges for empty panels and \
adds a check for screenId when executing a script for default panel layout. I&#39;m \
not much sure with the javascript part, but it works.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js \
<span style="color: grey">(47f635c)</span></li>

 <li>plasma/desktop/shell/desktopcorona.cpp <span style="color: \
grey">(d3635d9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116117/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 