From kde-panel-devel Thu Feb 27 14:07:12 2014 From: "Jan Grulich" Date: Thu, 27 Feb 2014 14:07:12 +0000 To: kde-panel-devel Subject: Review Request 116117: Place new panels to bottom by default Message-Id: <20140227140712.20354.68867 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139351006401493 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6077469362848603779==" --===============6077469362848603779== Content-Type: multipart/alternative; boundary="===============5969003804642263159==" --===============5969003804642263159== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116117/ ----------------------------------------------------------- Review request for kde-workspace and Plasma. Repository: kde-workspace Description ------- When adding a new empty panel, it's placed at top by default, but it should be placed to bottom, when it's possible. Also when adding a new "Default Panel" to second screen without any panel and you already have one on your first screen, then it's also placed to top instead of bottom. This is just a simple fix, which changes order of checking free edges for empty panels and adds a check for screenId when executing a script for default panel layout. I'm not much sure with the javascript part, but it works. Diffs ----- plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js 47f635c plasma/desktop/shell/desktopcorona.cpp d3635d9 Diff: https://git.reviewboard.kde.org/r/116117/diff/ Testing ------- Thanks, Jan Grulich --===============5969003804642263159== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116117/

Review request for kde-workspace and Plasma.

By Jan Grulich.

Repository: kde-workspace

Description

When adding a new empty panel, it's placed at top by default, but it should be placed to bottom, when it's possible. Also when adding a new "Default Panel" to second screen without any panel and you already have one on your first screen, then it's also placed to top instead of bottom. This is just a simple fix, which changes order of checking free edges for empty panels and adds a check for screenId when executing a script for default panel layout. I'm not much sure with the javascript part, but it works.

Diffs

plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js (47f635c)
plasma/desktop/shell/desktopcorona.cpp (d3635d9)

View Diff

--===============5969003804642263159==-- --===============6077469362848603779== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6077469362848603779==--