'Re: Review Request 115657: Ensure kcm cursor doesn't crash when started on Wayland'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115657: Ensure kcm cursor doesn't crash when started on Wayland
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-02-27 9:31:16
Message-ID: 20140227093116.20355.56987 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115657/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 9:31 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: kde-workspace

Description
-------

Ensure kcm cursor doesn't crash when started on Wayland

Unfortunately this means at the moment that it doesn't list any cursor
themes at all as the only available cursor theme backend is XCursor
based. But the app design should allow to implement a Wayland backend
without the need of large redesign.

Diffs
-----

  kcontrol/input/xcursor/themepage.cpp 6610ef299a545dcff7fc5e38d137f3bbca81954d 
  kcontrol/input/xcursor/thememodel.cpp 9f86fc910dafb445449c01bc9980eec92708cb84 

Diff: https://git.reviewboard.kde.org/r/115657/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115657/">https://git.reviewboard.kde.org/r/115657/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 27, 2014, 9:31 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ensure kcm cursor doesn&#39;t crash when started on Wayland

Unfortunately this means at the moment that it doesn&#39;t list any cursor
themes at all as the only available cursor theme backend is XCursor
based. But the app design should allow to implement a Wayland backend
without the need of large redesign.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/input/xcursor/themepage.cpp <span style="color: \
grey">(6610ef299a545dcff7fc5e38d137f3bbca81954d)</span></li>

 <li>kcontrol/input/xcursor/thememodel.cpp <span style="color: \
grey">(9f86fc910dafb445449c01bc9980eec92708cb84)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115657/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 