'Re: Review Request 115657: Ensure kcm cursor doesn't crash when started on Wayland'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115657: Ensure kcm cursor doesn't crash when started on Wayland
From:       "Commit Hook" <null () kde ! org>
Date:       2014-02-27 9:31:14
Message-ID: 20140227093114.20354.11977 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115657/#review51004
-----------------------------------------------------------

This review has been submitted with commit ff7760fc1291d0f5f479f66d76b86de928b7bd1d \
by Martin Gräßlin to branch master.

- Commit Hook

On Feb. 11, 2014, 1:23 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115657/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 1:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Ensure kcm cursor doesn't crash when started on Wayland
> 
> Unfortunately this means at the moment that it doesn't list any cursor
> themes at all as the only available cursor theme backend is XCursor
> based. But the app design should allow to implement a Wayland backend
> without the need of large redesign.
> 
> 
> Diffs
> -----
> 
> kcontrol/input/xcursor/themepage.cpp 6610ef299a545dcff7fc5e38d137f3bbca81954d 
> kcontrol/input/xcursor/thememodel.cpp 9f86fc910dafb445449c01bc9980eec92708cb84 
> 
> Diff: https://git.reviewboard.kde.org/r/115657/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115657/">https://git.reviewboard.kde.org/r/115657/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ff7760fc1291d0f5f479f66d76b86de928b7bd1d by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On February 11th, 2014, 1:23 p.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 11, 2014, 1:23 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ensure kcm cursor doesn&#39;t crash when started on Wayland

Unfortunately this means at the moment that it doesn&#39;t list any cursor
themes at all as the only available cursor theme backend is XCursor
based. But the app design should allow to implement a Wayland backend
without the need of large redesign.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/input/xcursor/themepage.cpp <span style="color: \
grey">(6610ef299a545dcff7fc5e38d137f3bbca81954d)</span></li>

 <li>kcontrol/input/xcursor/thememodel.cpp <span style="color: \
grey">(9f86fc910dafb445449c01bc9980eec92708cb84)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115657/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 