[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116085: welcome back the javascript interactive console
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-02-26 15:47:50
Message-ID: 20140226154750.5643.33555 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50941
-----------------------------------------------------------
src/shell/interactiveconsole.h
<https://git.reviewboard.kde.org/r/116085/#comment35763>
Is this copied from somewhere then?
Update copyright if you need to, otherwise ignore this.
src/shell/interactiveconsole.cpp
<https://git.reviewboard.kde.org/r/116085/#comment35757>
Are you not doing that on line 130?
src/shell/interactiveconsole.cpp
<https://git.reviewboard.kde.org/r/116085/#comment35758>
m_closeWhenCompleted should be initialised
to be consistent m_output should be too; but that's at least set in the ctor somewhere.
src/shell/interactiveconsole.cpp
<https://git.reviewboard.kde.org/r/116085/#comment35761>
this isn't a very helpful debug message :)
- David Edmundson
On Feb. 26, 2014, 3:25 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2014, 3:25 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> this ports the js interactive console from plasma1 and ports it way from kde4support
>
> ui-wise it should look the same
>
>
> Diffs
> -----
>
> src/shell/scripting/scriptengine.cpp 29735a0
> src/shell/shellcorona.cpp e84e0bf
> src/shell/shellpluginloader.cpp c57b348
> src/shell/CMakeLists.txt db0e569
> src/shell/interactiveconsole.h PRE-CREATION
> src/shell/interactiveconsole.cpp PRE-CREATION
> src/shell/packages.h 999b4c9
> src/shell/packages.cpp 0b2aa3f
> src/shell/scripting/layouttemplatepackagestructure.h abc5562
> src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca
>
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
>
>
> Testing
> -------
>
> tried to add plasmoids from the console
>
>
> Thanks,
>
> Marco Martin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116085/">https://git.reviewboard.kde.org/r/116085/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116085/diff/1/?file=246319#file246319line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/shell/interactiveconsole.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Copyright 2009 Aaron Seigo <aseigo@kde.org></span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this \
copied from somewhere then? Update copyright if you need to, otherwise ignore \
this.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116085/diff/1/?file=246320#file246320line57" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/shell/interactiveconsole.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">57</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// use text editor KPart for syntax highlighting?</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you not \
doing that on line 130?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116085/diff/1/?file=246320#file246320line76" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/shell/interactiveconsole.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">76</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_mode</span><span class="p">(</span><span \
class="n">PlasmaConsole</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">m_closeWhenCompleted should be initialised
to be consistent m_output should be too; but that's at least set in the ctor \
somewhere.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116085/diff/1/?file=246320#file246320line204" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/shell/interactiveconsole.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">204</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qDebug</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this \
isn't a very helpful debug message :)</pre> </div>
<br />
<p>- David Edmundson</p>
<br />
<p>On February 26th, 2014, 3:25 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2014, 3:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this ports the js interactive console from plasma1 and ports it way from \
kde4support
ui-wise it should look the same</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tried to add plasmoids from the console</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/shell/scripting/scriptengine.cpp <span style="color: \
grey">(29735a0)</span></li>
<li>src/shell/shellcorona.cpp <span style="color: grey">(e84e0bf)</span></li>
<li>src/shell/shellpluginloader.cpp <span style="color: grey">(c57b348)</span></li>
<li>src/shell/CMakeLists.txt <span style="color: grey">(db0e569)</span></li>
<li>src/shell/interactiveconsole.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/shell/interactiveconsole.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/shell/packages.h <span style="color: grey">(999b4c9)</span></li>
<li>src/shell/packages.cpp <span style="color: grey">(0b2aa3f)</span></li>
<li>src/shell/scripting/layouttemplatepackagestructure.h <span style="color: \
grey">(abc5562)</span></li>
<li>src/shell/scripting/layouttemplatepackagestructure.cpp <span style="color: \
grey">(bc1d0ca)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116085/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic