'Re: Review Request 116027: High dpi support for Svg'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116027: High dpi support for Svg
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-02-26 15:42:07
Message-ID: 20140226154207.5643.63406 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116027/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 3:42 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-framework

Description
-------

This gives support in Svg for devicePixelRatio, just exposed in the api from Svg \
side.

on the component side, it sets the devicepixelratio of the svg and framesvg with \
units. devicepixelratio is always set integer in the svg, so needs at least 192dpi to \
double up. (it needs to be integer to have lines contained inside a svg piece to keep \
being pixel aligned)

Diffs
-----

  src/declarativeimports/core/framesvgitem.h e348c4c 
  src/declarativeimports/core/framesvgitem.cpp 1826d88 
  src/declarativeimports/core/svgitem.h c8be7cc 
  src/declarativeimports/core/svgitem.cpp e90751a 
  src/declarativeimports/plasmacomponents/qml/ToolButton.qml 2319879 
  src/plasma/framesvg.h 482956d 
  src/plasma/framesvg.cpp 9e1a53e 
  src/plasma/private/framesvg_p.h 1bbc744 
  src/plasma/private/svg_p.h 332efda 
  src/plasma/svg.h 01d98f8 
  src/plasma/svg.cpp 9ec2aa5 

Diff: https://git.reviewboard.kde.org/r/116027/diff/

Testing
-------

unfortunately i can only test by hardcoding different values and check if the layout \
of the widgets stays correct, and is fine, it would be needed somebody with a retina \
screen to see it really in action

Thanks,

Marco Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116027/">https://git.reviewboard.kde.org/r/116027/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2014, 3:42 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This gives support in Svg for devicePixelRatio, just exposed in the api \
from Svg side.

on the component side, it sets the devicepixelratio of the svg and framesvg with \
units. devicepixelratio is always set integer in the svg, so needs at least 192dpi to \
double up. (it needs to be integer to have lines contained inside a svg piece to keep \
being pixel aligned)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">unfortunately i can only test by hardcoding different values and check \
if the layout of the widgets stays correct, and is fine, it would be needed somebody \
with a retina screen to see it really in action</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/framesvgitem.h <span style="color: \
grey">(e348c4c)</span></li>

 <li>src/declarativeimports/core/framesvgitem.cpp <span style="color: \
grey">(1826d88)</span></li>

 <li>src/declarativeimports/core/svgitem.h <span style="color: \
grey">(c8be7cc)</span></li>

 <li>src/declarativeimports/core/svgitem.cpp <span style="color: \
grey">(e90751a)</span></li>

 <li>src/declarativeimports/plasmacomponents/qml/ToolButton.qml <span style="color: \
grey">(2319879)</span></li>

 <li>src/plasma/framesvg.h <span style="color: grey">(482956d)</span></li>

 <li>src/plasma/framesvg.cpp <span style="color: grey">(9e1a53e)</span></li>

 <li>src/plasma/private/framesvg_p.h <span style="color: grey">(1bbc744)</span></li>

 <li>src/plasma/private/svg_p.h <span style="color: grey">(332efda)</span></li>

 <li>src/plasma/svg.h <span style="color: grey">(01d98f8)</span></li>

 <li>src/plasma/svg.cpp <span style="color: grey">(9ec2aa5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116027/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 