[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115224: Remove unused property drawWallpaper
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-01-30 14:35:05
Message-ID: 20140130143505.2191.88348 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115224/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 2:35 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-framework
Description
-------
Remove unused property drawWallpaper
As suggested here: http://community.kde.org/Plasma/libplasma2/API_Review/Containment
kde-workspace doesn't use it.
Diffs
-----
src/plasma/containment.h 1d747c6
src/plasma/containment.cpp 590402a
src/plasma/corona.cpp 9a937b0
src/plasma/private/containment_p.h 597f26e
src/plasma/scripting/appletscript.h 65301d4
src/plasma/scripting/appletscript.cpp cb9df7d
src/plasmaquick/plasmaquickview.cpp 03fe00e
src/scriptengines/qml/plasmoid/containmentinterface.h 0ed5868
src/scriptengines/qml/plasmoid/containmentinterface.cpp 23edb67
Diff: https://git.reviewboard.kde.org/r/115224/diff/
Testing
-------
Thanks,
David Edmundson
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115224/">https://git.reviewboard.kde.org/r/115224/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2014, 2:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove unused property drawWallpaper
As suggested here: http://community.kde.org/Plasma/libplasma2/API_Review/Containment
kde-workspace doesn't use it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/containment.h <span style="color: grey">(1d747c6)</span></li>
<li>src/plasma/containment.cpp <span style="color: grey">(590402a)</span></li>
<li>src/plasma/corona.cpp <span style="color: grey">(9a937b0)</span></li>
<li>src/plasma/private/containment_p.h <span style="color: \
grey">(597f26e)</span></li>
<li>src/plasma/scripting/appletscript.h <span style="color: \
grey">(65301d4)</span></li>
<li>src/plasma/scripting/appletscript.cpp <span style="color: \
grey">(cb9df7d)</span></li>
<li>src/plasmaquick/plasmaquickview.cpp <span style="color: \
grey">(03fe00e)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.h <span style="color: \
grey">(0ed5868)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: \
grey">(23edb67)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115224/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic