From kde-panel-devel Thu Jan 30 14:35:05 2014 From: "David Edmundson" Date: Thu, 30 Jan 2014 14:35:05 +0000 To: kde-panel-devel Subject: Re: Review Request 115224: Remove unused property drawWallpaper Message-Id: <20140130143505.2191.88348 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139109252800912 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5988094972390212854==" --===============5988094972390212854== Content-Type: multipart/alternative; boundary="===============3061936908225406813==" --===============3061936908225406813== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115224/ ----------------------------------------------------------- (Updated Jan. 30, 2014, 2:35 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description ------- Remove unused property drawWallpaper As suggested here: http://community.kde.org/Plasma/libplasma2/API_Review/Containment kde-workspace doesn't use it. Diffs ----- src/plasma/containment.h 1d747c6 src/plasma/containment.cpp 590402a src/plasma/corona.cpp 9a937b0 src/plasma/private/containment_p.h 597f26e src/plasma/scripting/appletscript.h 65301d4 src/plasma/scripting/appletscript.cpp cb9df7d src/plasmaquick/plasmaquickview.cpp 03fe00e src/scriptengines/qml/plasmoid/containmentinterface.h 0ed5868 src/scriptengines/qml/plasmoid/containmentinterface.cpp 23edb67 Diff: https://git.reviewboard.kde.org/r/115224/diff/ Testing ------- Thanks, David Edmundson --===============3061936908225406813== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115224/

This change has been marked as submitted.


Review request for Plasma.
By David Edmundson.

Updated Jan. 30, 2014, 2:35 p.m.

Repository: plasma-framework

Description

Remove unused property drawWallpaper

As suggested here: http://community.kde.org/Plasma/libplasma2/API_Review/Containment
kde-workspace doesn't use it.

Diffs

  • src/plasma/containment.h (1d747c6)
  • src/plasma/containment.cpp (590402a)
  • src/plasma/corona.cpp (9a937b0)
  • src/plasma/private/containment_p.h (597f26e)
  • src/plasma/scripting/appletscript.h (65301d4)
  • src/plasma/scripting/appletscript.cpp (cb9df7d)
  • src/plasmaquick/plasmaquickview.cpp (03fe00e)
  • src/scriptengines/qml/plasmoid/containmentinterface.h (0ed5868)
  • src/scriptengines/qml/plasmoid/containmentinterface.cpp (23edb67)

View Diff

--===============3061936908225406813==-- --===============5988094972390212854== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5988094972390212854==--