'Re: Review Request 115301: Add OSD notifications to plasma-shell'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115301: Add OSD notifications to plasma-shell
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2014-01-28 14:24:56
Message-ID: 20140128142456.5775.35254 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115301/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 2:24 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-framework

Description
-------

As we decided to make the OSD available only for certain things, the API is \
intentionally limited to very particular set of things. The list is not complete yet \
I believe, but I'd like to get comments on the general design and state.

Also as it's not a public service, I left it under org.kde.plasma_shell on D-Bus. \
Makes sense? Does not? Should it be standalone at eg. org.kde.osd?

Note: This still needs patches in kwin.

Diffs
-----

  src/shell/shellcorona.cpp f565d79 
  src/shell/osd.cpp PRE-CREATION 
  src/shell/osd.h PRE-CREATION 
  src/shell/CMakeLists.txt 5c4b360 

Diff: https://git.reviewboard.kde.org/r/115301/diff/

Testing
-------

Can be invoked using qdbus from command line. Works rather well.

Thanks,

Martin Klapetek

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115301/">https://git.reviewboard.kde.org/r/115301/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated Jan. 28, 2014, 2:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As we decided to make the OSD available only for certain things, the API \
is intentionally limited to very particular set of things. The list is not complete \
yet I believe, but I&#39;d like to get comments on the general design and state.

Also as it&#39;s not a public service, I left it under org.kde.plasma_shell on D-Bus. \
Makes sense? Does not? Should it be standalone at eg. org.kde.osd?

Note: This still needs patches in kwin.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Can be invoked using qdbus from command line. Works rather well.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/shell/shellcorona.cpp <span style="color: grey">(f565d79)</span></li>

 <li>src/shell/osd.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/shell/osd.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/shell/CMakeLists.txt <span style="color: grey">(5c4b360)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115301/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 