This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/

This change has been marked as submitted.


Review request for Plasma.
By Martin Klapetek.

Updated Jan. 28, 2014, 2:24 p.m.

Repository: plasma-framework

Description

As we decided to make the OSD available only for certain things, the API is intentionally limited to very particular set of things. The list is not complete yet I believe, but I'd like to get comments on the general design and state.

Also as it's not a public service, I left it under org.kde.plasma_shell on D-Bus. Makes sense? Does not? Should it be standalone at eg. org.kde.osd?

Note: This still needs patches in kwin.

Testing

Can be invoked using qdbus from command line. Works rather well.

Diffs

  • src/shell/shellcorona.cpp (f565d79)
  • src/shell/osd.cpp (PRE-CREATION)
  • src/shell/osd.h (PRE-CREATION)
  • src/shell/CMakeLists.txt (5c4b360)

View Diff