[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115162: Launch single instance of plasma-mediacenter
From: "Sujith Haridasan" <sujith.h () gmail ! com>
Date: 2014-01-22 4:18:27
Message-ID: 20140122041827.3955.54079 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 21, 2014, 5:58 p.m., Shantanu Tushar wrote:
> > I couldn't try it right now but I have this doubt. If there is already a PMC \
> > instance running and open a file from Dolphin, does the file indeed start \
> > playing?
What I meant to say is if PMC is already running and if user tries to open a file \
from Dolphin then there will be only one instance running which will be the first \
running instance. And hence the file tried to open via Dolphin has no effect. So \
nothing happens to running instance.
- Sujith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115162/#review47915
-----------------------------------------------------------
On Jan. 21, 2014, 6:44 a.m., Sujith Haridasan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115162/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 6:44 a.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Launching single instance of plasma-mediacenter. Using KUniqueApplication only \
> single instance of plasma-mediacenter is launched.
>
> Diffs
> -----
>
> shells/newshell/CMakeLists.txt 60949df
> shells/newshell/application.h PRE-CREATION
> shells/newshell/application.cpp PRE-CREATION
> shells/newshell/main.cpp 9fd5df3
> shells/newshell/plasma-mediacenter.desktop c3c5781
>
> Diff: https://git.reviewboard.kde.org/r/115162/diff/
>
>
> Testing
> -------
>
> Tests done using konsole:
> a) Open a tab and launch pmc.
> b) Open another tab and try to launch another instance of pmc.
> c) After executing (b) pmc wont launch because already another instance of pmc from \
> (a) is already running.
> Tests done using Dolphin:
> a) Go to the music folder and right click on the file to be played. Click open with \
> and launch pmc. b) Try to open another file using same step as (a)
> c) After executing (b) wait for few seconds and you can see that only single \
> instance of (a) will be running.
>
> Thanks,
>
> Sujith Haridasan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115162/">https://git.reviewboard.kde.org/r/115162/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 21st, 2014, 5:58 p.m. UTC, <b>Shantanu \
Tushar</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I couldn't try it right now but I have this doubt. If there is \
already a PMC instance running and open a file from Dolphin, does the file indeed \
start playing?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What I meant to say is \
if PMC is already running and if user tries to open a file from Dolphin then there \
will be only one instance running which will be the first running instance. And hence \
the file tried to open via Dolphin has no effect. So nothing happens to running \
instance.</pre> <br />
<p>- Sujith</p>
<br />
<p>On January 21st, 2014, 6:44 a.m. UTC, Sujith Haridasan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2014, 6:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Launching single instance of plasma-mediacenter. Using \
KUniqueApplication only single instance of plasma-mediacenter is launched.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests done using konsole: a) Open a tab and launch pmc.
b) Open another tab and try to launch another instance of pmc.
c) After executing (b) pmc wont launch because already another instance of pmc from \
(a) is already running.
Tests done using Dolphin:
a) Go to the music folder and right click on the file to be played. Click open with \
and launch pmc. b) Try to open another file using same step as (a)
c) After executing (b) wait for few seconds and you can see that only single instance \
of (a) will be running.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shells/newshell/CMakeLists.txt <span style="color: grey">(60949df)</span></li>
<li>shells/newshell/application.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/newshell/application.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/newshell/main.cpp <span style="color: grey">(9fd5df3)</span></li>
<li>shells/newshell/plasma-mediacenter.desktop <span style="color: \
grey">(c3c5781)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115162/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic