[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115162: Launch single instance of plasma-mediacenter
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2014-01-21 17:58:56
Message-ID: 20140121175856.4495.47940 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115162/#review47915
-----------------------------------------------------------
I couldn't try it right now but I have this doubt. If there is already a PMC instance \
running and open a file from Dolphin, does the file indeed start playing?
shells/newshell/application.cpp
<https://git.reviewboard.kde.org/r/115162/#comment33931>
use initialization lists syntax-
Application::Application()
: KUniqueApplication()
, m_mainWindow(0)
shells/newshell/application.cpp
<https://git.reviewboard.kde.org/r/115162/#comment33932>
Pass this as parent so that it can be deleted when the application exits
m_mainWindow = new MainWindow(this);
- Shantanu Tushar
On Jan. 21, 2014, 6:44 a.m., Sujith Haridasan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115162/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 6:44 a.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Launching single instance of plasma-mediacenter. Using KUniqueApplication only \
> single instance of plasma-mediacenter is launched.
>
> Diffs
> -----
>
> shells/newshell/CMakeLists.txt 60949df
> shells/newshell/application.h PRE-CREATION
> shells/newshell/application.cpp PRE-CREATION
> shells/newshell/main.cpp 9fd5df3
> shells/newshell/plasma-mediacenter.desktop c3c5781
>
> Diff: https://git.reviewboard.kde.org/r/115162/diff/
>
>
> Testing
> -------
>
> Tests done using konsole:
> a) Open a tab and launch pmc.
> b) Open another tab and try to launch another instance of pmc.
> c) After executing (b) pmc wont launch because already another instance of pmc from \
> (a) is already running.
> Tests done using Dolphin:
> a) Go to the music folder and right click on the file to be played. Click open with \
> and launch pmc. b) Try to open another file using same step as (a)
> c) After executing (b) wait for few seconds and you can see that only single \
> instance of (a) will be running.
>
> Thanks,
>
> Sujith Haridasan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115162/">https://git.reviewboard.kde.org/r/115162/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I couldn't try it \
right now but I have this doubt. If there is already a PMC instance running and open \
a file from Dolphin, does the file indeed start playing?</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115162/diff/1/?file=234888#file234888line28" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shells/newshell/application.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_mainWindow</span> <span class="o">=</span> <span class="mi">0</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use \
initialization lists syntax-
Application::Application()
: KUniqueApplication()
, m_mainWindow(0)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115162/diff/1/?file=234888#file234888line39" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shells/newshell/application.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">39</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_mainWindow</span> <span class="o">=</span> <span class="k">new</span> \
<span class="n">MainWindow</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pass this \
as parent so that it can be deleted when the application exits
m_mainWindow = new MainWindow(this);</pre>
</div>
<br />
<p>- Shantanu Tushar</p>
<br />
<p>On January 21st, 2014, 6:44 a.m. UTC, Sujith Haridasan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2014, 6:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Launching single instance of plasma-mediacenter. Using \
KUniqueApplication only single instance of plasma-mediacenter is launched.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests done using konsole: a) Open a tab and launch pmc.
b) Open another tab and try to launch another instance of pmc.
c) After executing (b) pmc wont launch because already another instance of pmc from \
(a) is already running.
Tests done using Dolphin:
a) Go to the music folder and right click on the file to be played. Click open with \
and launch pmc. b) Try to open another file using same step as (a)
c) After executing (b) wait for few seconds and you can see that only single instance \
of (a) will be running.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shells/newshell/CMakeLists.txt <span style="color: grey">(60949df)</span></li>
<li>shells/newshell/application.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/newshell/application.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/newshell/main.cpp <span style="color: grey">(9fd5df3)</span></li>
<li>shells/newshell/plasma-mediacenter.desktop <span style="color: \
grey">(c3c5781)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115162/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic