'Re: Review Request 114741: Add time duration to media item for youtube videos.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114741: Add time duration to media item for youtube videos.
From:       "Sinny Kumari" <ksinny () gmail ! com>
Date:       2013-12-31 16:12:23
Message-ID: 20131231161223.12418.73343 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114741/#review46511
-----------------------------------------------------------

Ship it!

Thanks for the patch. Works absolutely fine :)

- Sinny Kumari

On Dec. 31, 2013, 6:46 a.m., Sudhendu Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114741/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 6:46 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> While searching for youtube videos from PMC, it was difficult to differentiate \
> among the videos of same kind but different duration. This feature adds the \
> duration of video at top-right corner of thumbnail. Snapshot added along with this \
> review. 
> 
> Diffs
> -----
> 
> libs/mediacenter/mediacenter.h 7cdf285 
> libs/mediacenter/mediacenter.cpp 009ce22 
> browsingbackends/onlineservices/youtube/youtubemodel.cpp abb4f89 
> components/common/LabelOverlay.qml fd722af 
> components/common/MediaItem.qml ccdc8c2 
> 
> Diff: https://git.reviewboard.kde.org/r/114741/diff/
> 
> 
> Testing
> -------
> 
> Works good.
> 
> 
> File Attachments
> ----------------
> 
> snapshot3.png
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/30/a1194a19-4412-43cf-92ff-3bf150bbd38c__snapshot3.png
>  
> 
> Thanks,
> 
> Sudhendu Kumar
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114741/">https://git.reviewboard.kde.org/r/114741/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch. \
Works absolutely fine :)</pre>  <br />

<p>- Sinny Kumari</p>

<br />
<p>On December 31st, 2013, 6:46 a.m. UTC, Sudhendu Kumar wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Sudhendu Kumar.</div>

<p style="color: grey;"><i>Updated Dec. 31, 2013, 6:46 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While searching for youtube videos from PMC, it was difficult to \
differentiate among the videos of same kind but different duration. This feature adds \
the duration of video at top-right corner of thumbnail. Snapshot added along with \
this review.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works good.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/mediacenter/mediacenter.h <span style="color: grey">(7cdf285)</span></li>

 <li>libs/mediacenter/mediacenter.cpp <span style="color: grey">(009ce22)</span></li>

 <li>browsingbackends/onlineservices/youtube/youtubemodel.cpp <span style="color: \
grey">(abb4f89)</span></li>

 <li>components/common/LabelOverlay.qml <span style="color: \
grey">(fd722af)</span></li>

 <li>components/common/MediaItem.qml <span style="color: grey">(ccdc8c2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114741/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/30/a1194a19-4412-43cf-92ff-3bf150bbd38c__snapshot3.png">snapshot3.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 