From kde-panel-devel Tue Dec 31 16:12:23 2013 From: "Sinny Kumari" Date: Tue, 31 Dec 2013 16:12:23 +0000 To: kde-panel-devel Subject: Re: Review Request 114741: Add time duration to media item for youtube videos. Message-Id: <20131231161223.12418.73343 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138850637425043 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8832450938662332845==" --===============8832450938662332845== Content-Type: multipart/alternative; boundary="===============5047470386780851400==" --===============5047470386780851400== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114741/#review46511 ----------------------------------------------------------- Ship it! Thanks for the patch. Works absolutely fine :) - Sinny Kumari On Dec. 31, 2013, 6:46 a.m., Sudhendu Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114741/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2013, 6:46 a.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > While searching for youtube videos from PMC, it was difficult to differentiate among the videos of same kind but different duration. > This feature adds the duration of video at top-right corner of thumbnail. > Snapshot added along with this review. > > > Diffs > ----- > > libs/mediacenter/mediacenter.h 7cdf285 > libs/mediacenter/mediacenter.cpp 009ce22 > browsingbackends/onlineservices/youtube/youtubemodel.cpp abb4f89 > components/common/LabelOverlay.qml fd722af > components/common/MediaItem.qml ccdc8c2 > > Diff: https://git.reviewboard.kde.org/r/114741/diff/ > > > Testing > ------- > > Works good. > > > File Attachments > ---------------- > > snapshot3.png > https://git.reviewboard.kde.org/media/uploaded/files/2013/12/30/a1194a19-4412-43cf-92ff-3bf150bbd38c__snapshot3.png > > > Thanks, > > Sudhendu Kumar > > --===============5047470386780851400== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114741/

Ship it!

Thanks for the patch. Works absolutely fine :)

- Sinny Kumari


On December 31st, 2013, 6:46 a.m. UTC, Sudhendu Kumar wrote:

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
By Sudhendu Kumar.

Updated Dec. 31, 2013, 6:46 a.m.

Repository: plasma-mediacenter

Description 

While searching for youtube videos from PMC, it was difficult to differentiate among the videos of same kind but different duration.
This feature adds the duration of video at top-right corner of thumbnail.
Snapshot added along with this review.

Testing 

Works good.

Diffs

  • libs/mediacenter/mediacenter.h (7cdf285)
  • libs/mediacenter/mediacenter.cpp (009ce22)
  • browsingbackends/onlineservices/youtube/youtubemodel.cpp (abb4f89)
  • components/common/LabelOverlay.qml (fd722af)
  • components/common/MediaItem.qml (ccdc8c2)

View Diff

File Attachments

--===============5047470386780851400==-- --===============8832450938662332845== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8832450938662332845==--