'Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks
From:       "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date:       2013-12-23 13:25:17
Message-ID: 20131223132517.18784.30936 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114493/
-----------------------------------------------------------

(Updated Dec. 23, 2013, 1:25 p.m.)

Review request for Plasma.

Changes
-------

I have fix all the issues that they have been pointed out.

Repository: plasmate

Description
-------

This is a merge request for plasmoidviewer2 branch into the frameworks branch.

Plasmoidviewer2 branch contains some missing features and bug fixes.

Diffs (updated)
-----

  plasmate/CMakeLists.txt 55e7453 
  plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97 
  plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33 

Diff: https://git.reviewboard.kde.org/r/114493/diff/

Testing
-------

Thanks,

Antonis Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114493/">https://git.reviewboard.kde.org/r/114493/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Dec. 23, 2013, 1:25 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have fix all the issues that they have been pointed out. </pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a merge request for plasmoidviewer2 branch into the frameworks \
branch.

Plasmoidviewer2 branch contains some missing features and bug fixes.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmate/CMakeLists.txt <span style="color: grey">(55e7453)</span></li>

 <li>plasmate/publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(5f4de97)</span></li>

 <li>plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: \
grey">(3b41b33)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114493/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 