[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114564: Rename applet names to org.kde.plasma.* from org.kde.*
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2013-12-23 11:14:36
Message-ID: 20131223111436.18784.7598 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114564/
-----------------------------------------------------------
(Updated Dec. 23, 2013, 11:14 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Sebastian Kügler.
Repository: kde-workspace
Description
-------
Rename applets in plasma/desktop/* and plasma/generic/* that are ported. Renaming qml \
packages like panel and desktop is another patch because it requires changes in both \
plasma-framework and kde-workspace.
Please clean build, *install* and ~/.kf5 or ~/.project-neon5 directory after this is \
committed to master.
Diffs
-----
plasma/desktop/applets/CMakeLists.txt 02822ca
plasma/desktop/applets/kickoff/CMakeLists.txt a20fd33
plasma/desktop/applets/kickoff/package/metadata.desktop 3cf278d
plasma/desktop/applets/pager/CMakeLists.txt c922674
plasma/desktop/applets/pager/Messages.sh 0801aba
plasma/desktop/applets/pager/package/metadata.desktop d60fa72
plasma/desktop/applets/showActivityManager/CMakeLists.txt f1d6985
plasma/desktop/applets/showActivityManager/Messages.sh de5a66b
plasma/desktop/applets/showActivityManager/package/metadata.desktop 57acc46
plasma/desktop/applets/trash/metadata.desktop e46b2c3
plasma/desktop/applets/window-list/metadata.desktop 24c1b4a
plasma/generic/applets/CMakeLists.txt ffdb320
plasma/generic/applets/activitybar/Messages.sh dec8649
plasma/generic/applets/activitybar/metadata.desktop 89b0b4c
plasma/generic/applets/analog-clock/Messages.sh e3aa2ca
plasma/generic/applets/analog-clock/metadata.desktop df32eb9
plasma/generic/applets/calendar/metadata.desktop d3cf518
plasma/generic/applets/devicenotifier/CMakeLists.txt 51a1e20
plasma/generic/applets/devicenotifier/Messages.sh ffde1a7
plasma/generic/applets/devicenotifier/package/metadata.desktop 7db89cc
plasma/generic/applets/digital-clock/metadata.desktop 3a0b0fc
plasma/generic/applets/icon/CMakeLists.txt 27cefb7
plasma/generic/applets/icon/package/metadata.desktop 29d35e0
plasma/generic/applets/mediacontroller/metadata.desktop a7abf9e
plasma/generic/applets/notifications/CMakeLists.txt f1f8467
plasma/generic/applets/notifications/Messages.sh bd3e2d9
plasma/generic/applets/notifications/metadata.desktop 4e1b36f
plasma/generic/applets/systemtray2/CMakeLists.txt ec05c1e
plasma/generic/applets/systemtray2/Messages.sh bba43ab
plasma/generic/applets/systemtray2/package/metadata.desktop 52d093d
plasma/generic/applets/systemtray2/plugin/host.cpp 47fbb49
plasma/generic/applets/systemtray2/plugin/protocols/plasmoid/plasmoidinterface.cpp \
44d52e4 plasma/generic/applets/systemtray2/plugin/protocols/plasmoid/plasmoidprotocol.cpp \
8371107 plasma/qmlpackages/desktop/contents/layout.js 7358338
Diff: https://git.reviewboard.kde.org/r/114564/diff/
Testing
-------
added every applet to desktop, loaded.
Thanks,
Bhushan Shah
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114564/">https://git.reviewboard.kde.org/r/114564/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2013, 11:14 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rename applets in plasma/desktop/* and plasma/generic/* that are ported. \
Renaming qml packages like panel and desktop is another patch because it requires \
changes in both plasma-framework and kde-workspace.
Please clean build, *install* and ~/.kf5 or ~/.project-neon5 directory after this is \
committed to master.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">added every applet to desktop, loaded.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/CMakeLists.txt <span style="color: \
grey">(02822ca)</span></li>
<li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: \
grey">(a20fd33)</span></li>
<li>plasma/desktop/applets/kickoff/package/metadata.desktop <span style="color: \
grey">(3cf278d)</span></li>
<li>plasma/desktop/applets/pager/CMakeLists.txt <span style="color: \
grey">(c922674)</span></li>
<li>plasma/desktop/applets/pager/Messages.sh <span style="color: \
grey">(0801aba)</span></li>
<li>plasma/desktop/applets/pager/package/metadata.desktop <span style="color: \
grey">(d60fa72)</span></li>
<li>plasma/desktop/applets/showActivityManager/CMakeLists.txt <span style="color: \
grey">(f1d6985)</span></li>
<li>plasma/desktop/applets/showActivityManager/Messages.sh <span style="color: \
grey">(de5a66b)</span></li>
<li>plasma/desktop/applets/showActivityManager/package/metadata.desktop <span \
style="color: grey">(57acc46)</span></li>
<li>plasma/desktop/applets/trash/metadata.desktop <span style="color: \
grey">(e46b2c3)</span></li>
<li>plasma/desktop/applets/window-list/metadata.desktop <span style="color: \
grey">(24c1b4a)</span></li>
<li>plasma/generic/applets/CMakeLists.txt <span style="color: \
grey">(ffdb320)</span></li>
<li>plasma/generic/applets/activitybar/Messages.sh <span style="color: \
grey">(dec8649)</span></li>
<li>plasma/generic/applets/activitybar/metadata.desktop <span style="color: \
grey">(89b0b4c)</span></li>
<li>plasma/generic/applets/analog-clock/Messages.sh <span style="color: \
grey">(e3aa2ca)</span></li>
<li>plasma/generic/applets/analog-clock/metadata.desktop <span style="color: \
grey">(df32eb9)</span></li>
<li>plasma/generic/applets/calendar/metadata.desktop <span style="color: \
grey">(d3cf518)</span></li>
<li>plasma/generic/applets/devicenotifier/CMakeLists.txt <span style="color: \
grey">(51a1e20)</span></li>
<li>plasma/generic/applets/devicenotifier/Messages.sh <span style="color: \
grey">(ffde1a7)</span></li>
<li>plasma/generic/applets/devicenotifier/package/metadata.desktop <span \
style="color: grey">(7db89cc)</span></li>
<li>plasma/generic/applets/digital-clock/metadata.desktop <span style="color: \
grey">(3a0b0fc)</span></li>
<li>plasma/generic/applets/icon/CMakeLists.txt <span style="color: \
grey">(27cefb7)</span></li>
<li>plasma/generic/applets/icon/package/metadata.desktop <span style="color: \
grey">(29d35e0)</span></li>
<li>plasma/generic/applets/mediacontroller/metadata.desktop <span style="color: \
grey">(a7abf9e)</span></li>
<li>plasma/generic/applets/notifications/CMakeLists.txt <span style="color: \
grey">(f1f8467)</span></li>
<li>plasma/generic/applets/notifications/Messages.sh <span style="color: \
grey">(bd3e2d9)</span></li>
<li>plasma/generic/applets/notifications/metadata.desktop <span style="color: \
grey">(4e1b36f)</span></li>
<li>plasma/generic/applets/systemtray2/CMakeLists.txt <span style="color: \
grey">(ec05c1e)</span></li>
<li>plasma/generic/applets/systemtray2/Messages.sh <span style="color: \
grey">(bba43ab)</span></li>
<li>plasma/generic/applets/systemtray2/package/metadata.desktop <span style="color: \
grey">(52d093d)</span></li>
<li>plasma/generic/applets/systemtray2/plugin/host.cpp <span style="color: \
grey">(47fbb49)</span></li>
<li>plasma/generic/applets/systemtray2/plugin/protocols/plasmoid/plasmoidinterface.cpp \
<span style="color: grey">(44d52e4)</span></li>
<li>plasma/generic/applets/systemtray2/plugin/protocols/plasmoid/plasmoidprotocol.cpp \
<span style="color: grey">(8371107)</span></li>
<li>plasma/qmlpackages/desktop/contents/layout.js <span style="color: \
grey">(7358338)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114564/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic