[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114566: Plasmate: Port remoteinstaller to Qt5/KF5
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2013-12-21 13:51:14
Message-ID: 20131221135114.22692.57869 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114566/#review45989
-----------------------------------------------------------
plasmate/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114566/#comment32815>
No point committing commented code.
plasmate/publisher/remoteinstaller/remoteinstaller.cpp
<http://git.reviewboard.kde.org/r/114566/#comment32816>
This seems wrong.
from kde4support/src/kio/netaccess.h
static KDE4SUPPORT_DEPRECATED_EXPORT bool mkdir( const QUrl & url, QWidget* \
window, int permissions = -1 );
so you're casting book ok which is uninitialised to permissions - and then using \
that as the result.
Maybe you can explain why you had to change it?
plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp
<http://git.reviewboard.kde.org/r/114566/#comment32817>
You can't make a layout on the stack.
The lifetime of the layout needs to be as long as the RemoteInstallerDialog. This \
will be deleted as soon as we exit the constructor.
- David Edmundson
On Dec. 20, 2013, 4:02 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114566/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2013, 4:02 p.m.)
>
>
> Review request for Plasma and Giorgos Tsiapaliokas.
>
>
> Repository: plasmate
>
>
> Description
> -------
>
> Hello,
>
> This patch ports the remoteinstaller to Qt5/KF5.
>
>
> Diffs
> -----
>
> plasmate/CMakeLists.txt 55e7453
> plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97
> plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33
>
> Diff: http://git.reviewboard.kde.org/r/114566/diff/
>
>
> Testing
> -------
>
> I wasn't able to test if it works. Because remoteinstaller is using the \
> KUrlRequester, which it segfaults... I have open a thread on the frameworks ML.
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114566/">http://git.reviewboard.kde.org/r/114566/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114566/diff/1/?file=226723#file226723line154" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmate/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">154</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"><span \
class="hl">#</span> ${KDE4_KDEUI_LIBS}</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">154</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c"># ${KDE4_KDEUI_LIBS}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No point \
committing commented code.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114566/diff/1/?file=226724#file226724line44" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmate/publisher/remoteinstaller/remoteinstaller.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">43</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KIO</span><span class="o">::</span><span class="n">NetAccess</span><span \
class="o">::</span><span class="n">mkdir</span><span class="p">(</span><span \
class="n">tmpUrl</span><span class="p">,</span> <span class="n">m_widget</span><span \
class="p">,</span> <span class="n">ok</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems \
wrong.
from kde4support/src/kio/netaccess.h
static KDE4SUPPORT_DEPRECATED_EXPORT bool mkdir( const QUrl & url, QWidget* \
window, int permissions = -1 );
so you're casting book ok which is uninitialised to permissions - and then using \
that as the result.
Maybe you can explain why you had to change it?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114566/diff/1/?file=226725#file226725line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QVBoxLayout</span> <span class="n">l</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You \
can't make a layout on the stack.
The lifetime of the layout needs to be as long as the RemoteInstallerDialog. This \
will be deleted as soon as we exit the constructor.</pre> </div>
<br />
<p>- David Edmundson</p>
<br />
<p>On December 20th, 2013, 4:02 p.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Giorgos Tsiapaliokas.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2013, 4:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This patch ports the remoteinstaller to Qt5/KF5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I wasn't able to test if it works. Because remoteinstaller is using \
the KUrlRequester, which it segfaults... I have open a thread on the frameworks \
ML.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/CMakeLists.txt <span style="color: grey">(55e7453)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(5f4de97)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: \
grey">(3b41b33)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114566/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic