[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Regression from commit 5fdf522c
From:       Shantanu Tushar Jha <shantanu () kde ! org>
Date:       2013-12-18 6:21:51
Message-ID: CABQ4Km8fm4uK8=jvZ4XA7+WJkvLrCO7ZcLCJAJjQxvYd6UCYkw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Dec 18, 2013 at 10:27 AM, sujith h <sujith.h@gmail.com> wrote:

> Hi All,
> 
> Extremely sorry for the inconvenience caused by me. I didn't tested with
> Open with feautre
> 

Dude c'mon, this is very natural and happens all the time. You don't need
to be sorry for this, these things have to happen when we don't have tests
> P

with PMC. Thanks Shantanu that you pointed it out. This also gives us a
> lesson to test PMC
> with the test cases we haven't followed.
> 
> Thanks,
> 
> Sujith H
> 
> 
> On Wed, Dec 18, 2013 at 12:32 AM, Shantanu Tushar Jha <shantanu@kde.org>wrote:
> 
> > Hi folks,
> > 
> > I just noticed that commit \
> > 5fdf522c<https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository/revisions/5fdf522c413869d98135494cb2e379d4bf639ded>breaks \
> > Open With .. feature with PMC. The media get added to Default playlist while PMC \
> > switches to another playlist and plays that. I tried to fix this by creating a \
> > new playlist for command line media but our current design makes it very \
> > complicated to switch playlists from code on demand. 
> > Because the release is in 2 days, I will revert the commit, live without
> > that extra convenience. We can properly implement playlist switching in 1.3
> > so that this can be re-added.
> > 
> > Also, lets take this as a lesson to avoid the temptation of adding such
> > small conveniences after a beta release.
> > 
> > Thanks!
> > 
> > --
> > Shantanu Tushar    (UTC +0530)
> > http://www.shantanutushar.com
> > 
> 
> 
> 
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> 



-- 
Shantanu Tushar    (UTC +0530)
http://www.shantanutushar.com


[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 18, \
2013 at 10:27 AM, sujith h <span dir="ltr">&lt;<a href="mailto:sujith.h@gmail.com" \
target="_blank">sujith.h@gmail.com</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi All,<br><br></div>Extremely \
sorry for the inconvenience caused by me. I didn&#39;t tested with Open with \
feautre<br> </div></div></div></blockquote><div><br></div><div>Dude c&#39;mon, this \
is very natural and happens all the time. You don&#39;t need to be sorry for this, \
these things have to happen when we don&#39;t have tests :P<br><br> </div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div><div></div>with PMC. Thanks Shantanu that \
you pointed it out. This also gives us a lesson to test PMC<br>


with the test cases we haven&#39;t followed. <br><br></div>Thanks,<br><br>Sujith \
H<br><div><div><div><div><div class="gmail_extra"><div><div class="h5"><br><br><div \
class="gmail_quote">On Wed, Dec 18, 2013 at 12:32 AM, Shantanu Tushar Jha <span \
dir="ltr">&lt;<a href="mailto:shantanu@kde.org" \
target="_blank">shantanu@kde.org</a>&gt;</span> wrote:<br>


<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div>Hi folks,<br><br>I just noticed that \
commit <a href="https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository/revisions/5fdf522c413869d98135494cb2e379d4bf639ded" \
title="Revision 5fdf522c" target="_blank">5fdf522c</a>  breaks Open With .. feature \
with PMC. The media get added to Default  playlist while PMC switches to another \
playlist and plays that. I tried  to fix this by creating a new playlist for command \
line media but our  current design makes it very complicated to switch playlists from \
code  on demand.<br><br></div><div>Because the release is in 2 days, I will 
revert the commit, live without that extra convenience. We can properly 
implement playlist switching in 1.3 so that this can be \
re-added.<br></div><div><br></div><div>Also, lets take this as a lesson to avoid the \
temptation of adding such small conveniences after a beta release.<br><br></div>



Thanks!<span><font color="#888888"><br clear="all"><br>-- <br>Shantanu Tushar      \
(UTC +0530)<br><a href="http://www.shantanutushar.com" \
target="_blank">http://www.shantanutushar.com</a> </font></span></div>
</blockquote></div><br><br clear="all"><br></div></div><span class="HOEnZb"><font \
color="#888888">-- <br>സുജിത് \
ഹരിദാസന്<br>Bangalore<br>&lt;Project&gt;Contributor to KDE \
project<br><a href="http://fci.wikia.com/wiki/Anti-DRM-Campaign" \
target="_blank">http://fci.wikia.com/wiki/Anti-DRM-Campaign</a><br>


&lt;Blog&gt; <a href="http://sujithh.info" \
target="_blank">http://sujithh.info</a><br> \
</font></span></div></div></div></div></div></div> </blockquote></div><br><br \
clear="all"><br>-- <br>Shantanu Tushar      (UTC +0530)<br><a \
href="http://www.shantanutushar.com" \
target="_blank">http://www.shantanutushar.com</a> </div></div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic