[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2013-12-16 13:49:51
Message-ID: 20131216134951.18443.93035 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 16, 2013, 7:16 p.m., Sebastian Kügler wrote:
> > plasmoidviewer/CMakeLists.txt, line 22
> > <http://git.reviewboard.kde.org/r/114493/diff/2/?file=225327#file225327line22>
> >
> > Please make this org.kde.plasma.plasmoidviewershell, we're moving everything from \
> > org.kde.* to org.kde.plasma.*
@sebas If you don't mind can we install it to org.kde.plasmate.plasmoidviewershell? \
(Given this is not plasma stuff actually)
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114493/#review45779
-----------------------------------------------------------
On Dec. 16, 2013, 6:06 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114493/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 6:06 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasmate
>
>
> Description
> -------
>
> This is a merge request for plasmoidviewer2 branch into the frameworks branch.
>
> Plasmoidviewer2 branch contains some missing features and bug fixes.
>
>
> Diffs
> -----
>
> plasmoidviewer/CMakeLists.txt 30de8e2
> plasmoidviewer/fullview.h 7d4c70d
> plasmoidviewer/fullview.cpp 898931a
> plasmoidviewer/main.cpp f3cdb22
> plasmoidviewer/qmlpackages/containment/Messages.sh c8a9b60
> plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js 62e149a
> plasmoidviewer/qmlpackages/containment/contents/config/main.xml d889999
> plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml b23e098
> plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml 33d72c0
> plasmoidviewer/qmlpackages/containment/contents/ui/main.qml 6558710
> plasmoidviewer/qmlpackages/containment/metadata.desktop 9ddd217
> plasmoidviewer/qmlpackages/shell/contents/views/Background.qml PRE-CREATION
> plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml e5bedf3
> plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml PRE-CREATION
> plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml PRE-CREATION
> plasmoidviewer/view.h 0e2e48c
> plasmoidviewer/view.cpp fc008b0
>
> Diff: http://git.reviewboard.kde.org/r/114493/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114493/">http://git.reviewboard.kde.org/r/114493/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 16th, 2013, 7:16 p.m. IST, \
<b>Sebastian Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225327#file225327line22" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">22</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">plasma_install_package</span><span class="p">(</span><span \
class="s">qmlpackages/shell</span> <span class="s">org.kde.plasmoidviewershell</span> \
<span class="s">plasma/shells</span> <span class="s">shell</span><span \
class="p">)</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">21</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span \
class="nb">plasma_install_package</span><span class="p">(</span><span \
class="s">qmlpackages/shell</span> <span class="s">org.kde.plasmoidviewershell</span> \
<span class="s">plasma/shells</span> <span class="s">shell</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please make this \
org.kde.plasma.plasmoidviewershell, we're moving everything from org.kde.* to \
org.kde.plasma.*</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@sebas If \
you don't mind can we install it to org.kde.plasmate.plasmoidviewershell? (Given \
this is not plasma stuff actually)</pre> <br />
<p>- Bhushan</p>
<br />
<p>On December 16th, 2013, 6:06 p.m. IST, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2013, 6:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a merge request for plasmoidviewer2 branch into the frameworks \
branch.
Plasmoidviewer2 branch contains some missing features and bug fixes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoidviewer/CMakeLists.txt <span style="color: grey">(30de8e2)</span></li>
<li>plasmoidviewer/fullview.h <span style="color: grey">(7d4c70d)</span></li>
<li>plasmoidviewer/fullview.cpp <span style="color: grey">(898931a)</span></li>
<li>plasmoidviewer/main.cpp <span style="color: grey">(f3cdb22)</span></li>
<li>plasmoidviewer/qmlpackages/containment/Messages.sh <span style="color: \
grey">(c8a9b60)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js <span \
style="color: grey">(62e149a)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/config/main.xml <span \
style="color: grey">(d889999)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml <span \
style="color: grey">(b23e098)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml <span \
style="color: grey">(33d72c0)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/ui/main.qml <span style="color: \
grey">(6558710)</span></li>
<li>plasmoidviewer/qmlpackages/containment/metadata.desktop <span style="color: \
grey">(9ddd217)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Background.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <span style="color: \
grey">(e5bedf3)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/view.h <span style="color: grey">(0e2e48c)</span></li>
<li>plasmoidviewer/view.cpp <span style="color: grey">(fc008b0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114493/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic