'Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2013-12-16 13:46:40
Message-ID: 20131216134640.17791.80379 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114493/#review45779
-----------------------------------------------------------

plasmoidviewer/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114493/#comment32697>

    Please make this org.kde.plasma.plasmoidviewershell, we're moving everything from \
org.kde.* to org.kde.plasma.*

plasmoidviewer/main.cpp
<http://git.reviewboard.kde.org/r/114493/#comment32698>

    comment is wrong here

plasmoidviewer/main.cpp
<http://git.reviewboard.kde.org/r/114493/#comment32699>

    const

plasmoidviewer/main.cpp
<http://git.reviewboard.kde.org/r/114493/#comment32700>

    const

plasmoidviewer/main.cpp
<http://git.reviewboard.kde.org/r/114493/#comment32701>

    const

plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml
<http://git.reviewboard.kde.org/r/114493/#comment32709>

    This reads a bit weird. Maybe the signal should be called onFormFactorChanged?

    (Same for location just below.)

plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml
<http://git.reviewboard.kde.org/r/114493/#comment32710>

    signal should be "screenshotRequested()"?

plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml
<http://git.reviewboard.kde.org/r/114493/#comment32711>

    instead of the 8, use theme.largeSpacing /2 here, should give roughly the same \
value, but is DPI-independent.

plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml
<http://git.reviewboard.kde.org/r/114493/#comment32712>

    Does this button actually do anything? :)

plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml
<http://git.reviewboard.kde.org/r/114493/#comment32713>

    Does this button do anything?

plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
<http://git.reviewboard.kde.org/r/114493/#comment32716>

    here, location() as function call looks weird, make it setLocation()

plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
<http://git.reviewboard.kde.org/r/114493/#comment32715>

    Left Edge (those are two words), same for the other labels

plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
<http://git.reviewboard.kde.org/r/114493/#comment32714>

    typo, edget -> edge

plasmoidviewer/view.h
<http://git.reviewboard.kde.org/r/114493/#comment32704>

    QStringLiteral("planar")

plasmoidviewer/view.h
<http://git.reviewboard.kde.org/r/114493/#comment32705>

    QStringLiteral("floating")

plasmoidviewer/view.h
<http://git.reviewboard.kde.org/r/114493/#comment32702>

    setFormFactor(), change* indicates a from-to change, not the case here.

plasmoidviewer/view.h
<http://git.reviewboard.kde.org/r/114493/#comment32703>

    setLocation

plasmoidviewer/view.cpp
<http://git.reviewboard.kde.org/r/114493/#comment32706>

    Maybe give the applet name here, so it's easier to spot typos, for example?

plasmoidviewer/view.cpp
<http://git.reviewboard.kde.org/r/114493/#comment32707>

    Give containment name here, see above

plasmoidviewer/view.cpp
<http://git.reviewboard.kde.org/r/114493/#comment32708>

    Can applet->pluginInfo() be invalid here? If that's the case, we'll hit an ASSERT \
in KPluginInfo, better check.

- Sebastian Kügler

On Dec. 16, 2013, 12:36 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114493/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 12:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> This is a merge request for plasmoidviewer2 branch into the frameworks branch.
> 
> Plasmoidviewer2 branch contains some missing features and bug fixes.
> 
> 
> Diffs
> -----
> 
> plasmoidviewer/CMakeLists.txt 30de8e2 
> plasmoidviewer/fullview.h 7d4c70d 
> plasmoidviewer/fullview.cpp 898931a 
> plasmoidviewer/main.cpp f3cdb22 
> plasmoidviewer/qmlpackages/containment/Messages.sh c8a9b60 
> plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js 62e149a 
> plasmoidviewer/qmlpackages/containment/contents/config/main.xml d889999 
> plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml b23e098 
> plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml 33d72c0 
> plasmoidviewer/qmlpackages/containment/contents/ui/main.qml 6558710 
> plasmoidviewer/qmlpackages/containment/metadata.desktop 9ddd217 
> plasmoidviewer/qmlpackages/shell/contents/views/Background.qml PRE-CREATION 
> plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml e5bedf3 
> plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml PRE-CREATION 
> plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml PRE-CREATION 
> plasmoidviewer/view.h 0e2e48c 
> plasmoidviewer/view.cpp fc008b0 
> 
> Diff: http://git.reviewboard.kde.org/r/114493/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114493/">http://git.reviewboard.kde.org/r/114493/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225327#file225327line22" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">22</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">plasma_install_package</span><span class="p">(</span><span \
class="s">qmlpackages/shell</span> <span class="s">org.kde.plasmoidviewershell</span> \
<span class="s">plasma/shells</span> <span class="s">shell</span><span \
class="p">)</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">21</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span \
class="nb">plasma_install_package</span><span class="p">(</span><span \
class="s">qmlpackages/shell</span> <span class="s">org.kde.plasmoidviewershell</span> \
<span class="s">plasma/shells</span> <span class="s">shell</span><span \
class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please make \
this org.kde.plasma.plasmoidviewershell, we&#39;re moving everything from org.kde.* \
to org.kde.plasma.*</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225330#file225330line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/main.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char **argv)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">i18n</span><span class="p">(</span><span class="s">&quot;Set the x \
position of the plasmoidviewer on the plasma desktop&quot;</span><span \
class="p">),</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">comment is \
wrong here</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225330#file225330line101" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/main.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char **argv)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">101</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">QStringList</span> <span class="n">realSize</span> <span class="o">=</span> \
<span class="n">parser</span><span class="p">.</span><span \
class="n">value</span><span class="p">(</span><span \
class="s">&quot;size&quot;</span><span class="p">).</span><span \
class="n">split</span><span class="p">(</span><span class="n">QChar</span><span \
class="p">(</span><span class="sc">&#39;x&#39;</span><span \
class="p">));</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">const \
</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225330#file225330line102" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/main.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char **argv)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">102</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="kt">int</span> <span class="n">realWidth</span> <span class="o">=</span> <span \
class="n">realSize</span><span class="p">.</span><span class="n">at</span><span \
class="p">(</span><span class="mi">0</span><span class="p">).</span><span \
class="n">toInt</span><span class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">const</pre> \
</div> <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225330#file225330line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/main.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char **argv)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="kt">int</span> <span class="n">realHeight</span> <span class="o">=</span> \
<span class="n">realSize</span><span class="p">.</span><span class="n">at</span><span \
class="p">(</span><span class="mi">1</span><span class="p">).</span><span \
class="n">toInt</span><span class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">const</pre> \
</div> <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225339#file225339line44" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">44</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">onFormFactor:</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This reads \
a bit weird. Maybe the signal should be called onFormFactorChanged?

(Same for location just below.)</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225339#file225339line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">onRequestScreenshot:</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">signal \
should be &quot;screenshotRequested()&quot;?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225339#file225339line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">leftMargin:</span> <span class="nx">backgroundKonsole</span><span \
class="p">.</span><span class="nx">margins</span><span class="p">.</span><span \
class="nx">left</span> <span class="o">+</span> <span class="mi">8</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">instead of \
the 8, use theme.largeSpacing /2 here, should give roughly the same value, but is \
DPI-independent.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225340#file225340line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="nx">PlasmaComponents</span><span class="p">.</span><span \
class="nx">Button</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does this \
button actually do anything? :)</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225340#file225340line40" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">40</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="nx">PlasmaComponents</span><span class="p">.</span><span \
class="nx">Button</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does this \
button do anything?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225341#file225341line105" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">105</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="k">onClicked:</span> <span class="nx">location</span><span \
class="p">(</span><span class="nx">PlasmaCore</span><span class="p">.</span><span \
class="nx">Types</span><span class="p">.</span><span class="nx">Floating</span><span \
class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">here, \
location() as function call looks weird, make it setLocation()</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225341#file225341line124" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">124</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="k">text:</span> <span class="nx">i18n</span><span \
class="p">(</span><span class="s2">&quot;Leftedge&quot;</span><span \
class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Left Edge \
(those are two words), same for the other labels</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225341#file225341line128" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">128</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="k">text:</span> <span class="nx">i18n</span><span \
class="p">(</span><span class="s2">&quot;Rightedget&quot;</span><span \
class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">typo, edget \
-&gt; edge</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225342#file225342line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.h</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">33</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="nf">addFormFactor</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">formFactor</span> <span class="o">=</span> \
<span class="s">&quot;planar&quot;</span><span class="p">);</span></pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">35</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="nf">addFormFactor</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">formFactor</span> <span class="o">=</span> \
<span class="s">&quot;planar&quot;</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QStringLiteral(&quot;planar&quot;)</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225342#file225342line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.h</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">34</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="nf">addLocation</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">location</span> <span class="o">=</span> <span \
class="s">&quot;floating&quot;</span><span class="p">);</span></pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="nf">addLocation</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">location</span> <span class="o">=</span> <span \
class="s">&quot;floating&quot;</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QStringLiteral(&quot;floating&quot;)</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225342#file225342line40" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.h</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">39</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">Q_INVOKABLE</span> <span class="kt">void</span> <span \
class="nf">changeFormFactor</span><span class="p">(</span><span class="kt">int</span> \
<span class="n">formFactor</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">setFormFactor(), change* indicates a from-to change, not the case here. \
</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225342#file225342line41" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.h</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">40</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">Q_INVOKABLE</span> <span class="kt">void</span> <span \
class="nf">changeLocation</span><span class="p">(</span><span class="kt">int</span> \
<span class="n">location</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">setLocation</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225343#file225343line57" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
View::addApplet(const QString &amp;applet)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">50</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">qCritical</span><span class="p">(</span><span class="s">&quot;Applet \
doesn&#39;t exist!&quot;</span><span class="p">);</span></pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">57</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">qCritical</span><span class="p">(</span><span class="s">&quot;Applet \
doesn&#39;t exist!&quot;</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe give \
the applet name here, so it&#39;s easier to spot typos, for example?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225343#file225343line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
View::addApplet(const QString &amp;applet)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">59</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">qCritical</span><span class="p">(</span><span class="s">&quot;Containment \
doesn&#39;t exist&quot;</span><span class="p">);</span></pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">qCritical</span><span class="p">(</span><span class="s">&quot;Containment \
doesn&#39;t exist&quot;</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Give \
containment name here, see above</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/114493/diff/2/?file=225343#file225343line76" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
View::addApplet(const QString &amp;applet)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">76</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="n">addApplet</span><span class="p">(</span><span \
class="n">applet</span><span class="o">-&gt;</span><span \
class="n">pluginInfo</span><span class="p">().</span><span \
class="n">pluginName</span><span class="p">());</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can \
applet-&gt;pluginInfo() be invalid here? If that&#39;s the case, we&#39;ll hit an \
ASSERT in KPluginInfo, better check.</pre> </div>
<br />

<p>- Sebastian Kügler</p>

<br />
<p>On December 16th, 2013, 12:36 p.m. UTC, Antonis Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Dec. 16, 2013, 12:36 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a merge request for plasmoidviewer2 branch into the frameworks \
branch.

Plasmoidviewer2 branch contains some missing features and bug fixes.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmoidviewer/CMakeLists.txt <span style="color: grey">(30de8e2)</span></li>

 <li>plasmoidviewer/fullview.h <span style="color: grey">(7d4c70d)</span></li>

 <li>plasmoidviewer/fullview.cpp <span style="color: grey">(898931a)</span></li>

 <li>plasmoidviewer/main.cpp <span style="color: grey">(f3cdb22)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/Messages.sh <span style="color: \
grey">(c8a9b60)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js <span \
style="color: grey">(62e149a)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/config/main.xml <span \
style="color: grey">(d889999)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml <span \
style="color: grey">(b23e098)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml <span \
style="color: grey">(33d72c0)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/ui/main.qml <span style="color: \
grey">(6558710)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/metadata.desktop <span style="color: \
grey">(9ddd217)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/views/Background.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <span style="color: \
grey">(e5bedf3)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmoidviewer/view.h <span style="color: grey">(0e2e48c)</span></li>

 <li>plasmoidviewer/view.cpp <span style="color: grey">(fc008b0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114493/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 