'Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic
From:       "Sujith Haridasan" <sujith.h () gmail ! com>
Date:       2013-11-30 17:52:11
Message-ID: 20131130175211.10779.60984 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114223/
-----------------------------------------------------------

(Updated Nov. 30, 2013, 5:52 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Shantanu Tushar and Sinny Kumari.

Repository: plasma-mediacenter

Description
-------

Moving popup menu to mediacenter.qml and hence making it more generic. popup menu is \
pushed to the pagestack and hence it helps the user in keyboard navigation using Esc \
key too.

Diffs
-----

  shells/newshell/package/contents/ui/mediacenter.qml 860b794 
  mediaelements/popupmenu/PopupMenu.qml 6a832f7 
  mediaelements/mediabrowser/MediaBrowser.qml ec76b99 

Diff: http://git.reviewboard.kde.org/r/114223/diff/

Testing
-------

Tested by moving the popup menu to mediacenter by launching pmc. And also when \
pressed the Esc key it takes user to the files section of the media browser.

Thanks,

Sujith Haridasan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114223/">http://git.reviewboard.kde.org/r/114223/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>

<p style="color: grey;"><i>Updated Nov. 30, 2013, 5:52 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Moving popup menu to mediacenter.qml and hence making it more generic. \
popup menu is pushed to the pagestack and hence it helps the user in keyboard \
navigation using Esc key too.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by moving the popup menu to mediacenter by launching pmc. And \
also when pressed the Esc key it takes user to the files section of the media \
browser.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(860b794)</span></li>

 <li>mediaelements/popupmenu/PopupMenu.qml <span style="color: \
grey">(6a832f7)</span></li>

 <li>mediaelements/mediabrowser/MediaBrowser.qml <span style="color: \
grey">(ec76b99)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114223/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 