From kde-panel-devel Sat Nov 30 17:52:11 2013 From: "Sujith Haridasan" Date: Sat, 30 Nov 2013 17:52:11 +0000 To: kde-panel-devel Subject: Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic Message-Id: <20131130175211.10779.60984 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138583394719279 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8131759392436014156==" --===============8131759392436014156== Content-Type: multipart/alternative; boundary="===============5961819758554307004==" --===============5961819758554307004== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114223/ ----------------------------------------------------------- (Updated Nov. 30, 2013, 5:52 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description ------- Moving popup menu to mediacenter.qml and hence making it more generic. popup menu is pushed to the pagestack and hence it helps the user in keyboard navigation using Esc key too. Diffs ----- shells/newshell/package/contents/ui/mediacenter.qml 860b794 mediaelements/popupmenu/PopupMenu.qml 6a832f7 mediaelements/mediabrowser/MediaBrowser.qml ec76b99 Diff: http://git.reviewboard.kde.org/r/114223/diff/ Testing ------- Tested by moving the popup menu to mediacenter by launching pmc. And also when pressed the Esc key it takes user to the files section of the media browser. Thanks, Sujith Haridasan --===============5961819758554307004== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114223/

This change has been marked as submitted.

Review request for Plasma, Shantanu Tushar and Sinny Kumari.
By Sujith Haridasan.

Updated Nov. 30, 2013, 5:52 p.m.

Repository: plasma-mediacenter

Description 

Moving popup menu to mediacenter.qml and hence making it more generic. popup menu is pushed to the pagestack and hence it helps the user in keyboard navigation using Esc key too.

Testing 

Tested by moving the popup menu to mediacenter by launching pmc. And also when pressed the Esc key it takes user to the files section of the media browser.

Diffs

  • shells/newshell/package/contents/ui/mediacenter.qml (860b794)
  • mediaelements/popupmenu/PopupMenu.qml (6a832f7)
  • mediaelements/mediabrowser/MediaBrowser.qml (ec76b99)

View Diff
--===============5961819758554307004==-- --===============8131759392436014156== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8131759392436014156==--