[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114149: Fix plasma on multiple monitors
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-11-27 14:52:22
Message-ID: 20131127145222.12387.20241 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114149/#review44579
-----------------------------------------------------------
Ship it!
Tested and confirmed working here.
Once Martin's happy, go ahead and ship it.
- Sebastian Kügler
On Nov. 27, 2013, 11:34 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114149/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 11:34 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Set geometry to fill each screen correctly
>
> DesktopView incorrectly filled the geometry of screen()
> screen() will be the screen of the parent shell, not the correct
> screen.
>
> As we were already part-using QScreen, shellcorona is ported to use that instead
> of QDesktopWidget, so we can keep track of which screen is actually removed instead \
> of just assuming it was the last one.
>
> Diffs
> -----
>
> src/shell/desktopview.h b8b9caa
> src/shell/desktopview.cpp 90a5730
> src/shell/shellcorona.h ee5e2bc
> src/shell/shellcorona.cpp ef6fbe2
>
> Diff: http://git.reviewboard.kde.org/r/114149/diff/
>
>
> Testing
> -------
>
> Used two monitors, and I now have a different wallpaper on each \o/
>
> There's a crash on unplugging a monitor, this happens before my patch and appears \
> to be unrelated.
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114149/">http://git.reviewboard.kde.org/r/114149/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested and confirmed \
working here.
Once Martin's happy, go ahead and ship it.</pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On November 27th, 2013, 11:34 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2013, 11:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Set geometry to fill each screen correctly
DesktopView incorrectly filled the geometry of screen()
screen() will be the screen of the parent shell, not the correct
screen.
As we were already part-using QScreen, shellcorona is ported to use that instead
of QDesktopWidget, so we can keep track of which screen is actually removed instead \
of just assuming it was the last one. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used two monitors, and I now have a different wallpaper on each \o/
There's a crash on unplugging a monitor, this happens before my patch and appears \
to be unrelated.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/shell/desktopview.h <span style="color: grey">(b8b9caa)</span></li>
<li>src/shell/desktopview.cpp <span style="color: grey">(90a5730)</span></li>
<li>src/shell/shellcorona.h <span style="color: grey">(ee5e2bc)</span></li>
<li>src/shell/shellcorona.cpp <span style="color: grey">(ef6fbe2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114149/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic