[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114152: [GCI] FixPicturestrip navigation loop
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-11-27 14:38:18
Message-ID: 20131127143818.11006.4667 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/#review44577
-----------------------------------------------------------
Please specify in the description of the patch what it does, and what's wrong \
exactly, possibly why this is wrong.
You also forgot to mention how you verified the test works and doesn't break anything \
else.
This makes it hard to judge for a reviewer.
mediaelements/imageviewer/PictureStrip.qml
<http://git.reviewboard.kde.org/r/114152/#comment31822>
Generally, we put } else { on the same line.
mediaelements/imageviewer/PictureStrip.qml
<http://git.reviewboard.kde.org/r/114152/#comment31825>
In order to make it easier for reviewers, stylistic changes should be submitted \
in a separate review.
Imagine someone doing a git bisect in two years, and looks over this patch to see \
if it introduced a problem, and why. It should be as clear and concise as possible to \
read, so the reviewer can quickly decide if this matters, or not.
It's tempting to do stylistic changes, but not doing it makes it easier for \
reviewers to evaluate the patch.
mediaelements/imageviewer/PictureStrip.qml
<http://git.reviewboard.kde.org/r/114152/#comment31823>
on the same line, please
- Sebastian Kügler
On Nov. 27, 2013, 2:04 p.m., Egor Matirov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114152/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 2:04 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Fix Picturestrip navigation loop. GCI task: \
> http://www.google-melange.com/gci/task/view/google/gci2013/5783943471169536
>
> Diffs
> -----
>
> mediaelements/imageviewer/PictureStrip.qml 4825f2e
>
> Diff: http://git.reviewboard.kde.org/r/114152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Egor Matirov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114152/">http://git.reviewboard.kde.org/r/114152/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please specify in the \
description of the patch what it does, and what's wrong exactly, possibly why \
this is wrong.
You also forgot to mention how you verified the test works and doesn't break \
anything else.
This makes it hard to judge for a reviewer.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114152/diff/1/?file=220681#file220681line101" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/imageviewer/PictureStrip.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">101</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Generally, \
we put } else { on the same line.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114152/diff/1/?file=220681#file220681line112" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/imageviewer/PictureStrip.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">108</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">imageList</span><span class="p">.</span><span \
class="nx">currentItem</span><span class="p">.</span><span \
class="nx">emitClicked</span><span class="p">()</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">112</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">imageList</span><span class="p">.</span><span \
class="nx">currentItem</span><span class="p">.</span><span \
class="nx">emitClicked</span><span class="p">()<span \
class="hl">;</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order to \
make it easier for reviewers, stylistic changes should be submitted in a separate \
review.
Imagine someone doing a git bisect in two years, and looks over this patch to see if \
it introduced a problem, and why. It should be as clear and concise as possible to \
read, so the reviewer can quickly decide if this matters, or not.
It's tempting to do stylistic changes, but not doing it makes it easier for \
reviewers to evaluate the patch.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114152/diff/1/?file=220681#file220681line113" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/imageviewer/PictureStrip.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">113</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">on the same \
line, please</pre> </div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On November 27th, 2013, 2:04 p.m. UTC, Egor Matirov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Egor Matirov.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2013, 2:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix Picturestrip navigation loop. GCI task: \
http://www.google-melange.com/gci/task/view/google/gci2013/5783943471169536</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/imageviewer/PictureStrip.qml <span style="color: \
grey">(4825f2e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114152/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic