'Re: Review Request 114055: Include translatoins sub-directory to CMakeLists.txt , Fedora Packaging f'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114055: Include translatoins sub-directory to CMakeLists.txt , Fedora Packaging f
From:       "Sinny Kumari" <ksinny () gmail ! com>
Date:       2013-11-26 11:40:33
Message-ID: 20131126114033.21990.21147 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114055/#review44489
-----------------------------------------------------------

Ship it!

looks good to me. I checked on Fedora 19 and translation works fine there.
It would be great to know from others as well if these changes don't create any \
problem in other distro.

- Sinny Kumari

On Nov. 23, 2013, 5:23 p.m., Siddharth Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114055/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 5:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Include translatoins sub-directory to CMakeLists.txt
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt 25b607b 
> 
> Diff: http://git.reviewboard.kde.org/r/114055/diff/
> 
> 
> Testing
> -------
> 
> While packaging for fedora, it was not getting lang translations, post applying \
> this patch everything worked fine. 
> 
> Thanks,
> 
> Siddharth Sharma
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114055/">http://git.reviewboard.kde.org/r/114055/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good to me. I \
checked on Fedora 19 and translation works fine there. It would be great to know from \
others as well if these changes don&#39;t create any problem in other distro.</pre>  \
<br />

<p>- Sinny Kumari</p>

<br />
<p>On November 23rd, 2013, 5:23 p.m. UTC, Siddharth Sharma wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Siddharth Sharma.</div>

<p style="color: grey;"><i>Updated Nov. 23, 2013, 5:23 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Include translatoins sub-directory to CMakeLists.txt</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While packaging for fedora, it was not getting lang translations, post \
applying this patch everything worked fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(25b607b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114055/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 