From kde-panel-devel Tue Nov 26 11:40:33 2013 From: "Sinny Kumari" Date: Tue, 26 Nov 2013 11:40:33 +0000 To: kde-panel-devel Subject: Re: Review Request 114055: Include translatoins sub-directory to CMakeLists.txt , Fedora Packaging f Message-Id: <20131126114033.21990.21147 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138546604628677 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0761995543457394307==" --===============0761995543457394307== Content-Type: multipart/alternative; boundary="===============7107182717208473002==" --===============7107182717208473002== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114055/#review44489 ----------------------------------------------------------- Ship it! looks good to me. I checked on Fedora 19 and translation works fine there. It would be great to know from others as well if these changes don't create any problem in other distro. - Sinny Kumari On Nov. 23, 2013, 5:23 p.m., Siddharth Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114055/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2013, 5:23 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > Include translatoins sub-directory to CMakeLists.txt > > > Diffs > ----- > > CMakeLists.txt 25b607b > > Diff: http://git.reviewboard.kde.org/r/114055/diff/ > > > Testing > ------- > > While packaging for fedora, it was not getting lang translations, post applying this patch everything worked fine. > > > Thanks, > > Siddharth Sharma > > --===============7107182717208473002== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114055/

Ship it!

looks good to me. I checked on Fedora 19 and translation works fine there.
It would be great to know from others as well if these changes don't create any problem in other distro.

- Sinny Kumari

On November 23rd, 2013, 5:23 p.m. UTC, Siddharth Sharma wrote:

Review request for Plasma.

By Siddharth Sharma.

Updated Nov. 23, 2013, 5:23 p.m.

Repository: plasma-mediacenter

Description

Include translatoins sub-directory to CMakeLists.txt

Testing

While packaging for fedora, it was not getting lang translations, post applying this patch everything worked fine.

Diffs

CMakeLists.txt (25b607b)

View Diff

--===============7107182717208473002==-- --===============0761995543457394307== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0761995543457394307==--