[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114099: Make the calendar applet follow current locale
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2013-11-25 14:07:50
Message-ID: 20131125140750.462.69569 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 25, 2013, 1:02 p.m., Mark Gaiser wrote:
> > yeah.. and now this copied part + \
> > http://quickgit.kde.org/?p=kdepim-runtime.git&a=shortlog&h=a37e777b73c607f10f8ae87b0950509bab084ced \
> > are starting to diverge. Please also commit this to the "calendar_components" \
> > branch in kdepim-runtime.
Done.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114099/#review44389
-----------------------------------------------------------
On Nov. 25, 2013, 12:25 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114099/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2013, 12:25 p.m.)
>
>
> Review request for Plasma and Mark Gaiser.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> First day of week is now following locale's first day of week.
>
> Patch also adds comments (copied from kdepim-runtime) and renames startDay to \
> firstDayOfWeek to be more clear what it is.
>
> Diffs
> -----
>
> src/declarativeimports/calendar/calendar.h cc15fcd
> src/declarativeimports/calendar/calendar.cpp 91d95ac
> src/declarativeimports/calendar/qml/DaysCalendar.qml f80d1f9
> src/declarativeimports/calendar/qml/MonthView.qml 533253f
>
> Diff: http://git.reviewboard.kde.org/r/114099/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114099/">http://git.reviewboard.kde.org/r/114099/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 25th, 2013, 1:02 p.m. UTC, <b>Mark \
Gaiser</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yeah.. and now this copied part + \
http://quickgit.kde.org/?p=kdepim-runtime.git&a=shortlog&h=a37e777b73c607f10f8ae87b0950509bab084ced \
are starting to diverge. Please also commit this to the \
"calendar_components" branch in kdepim-runtime.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done.</pre> <br />
<p>- Martin</p>
<br />
<p>On November 25th, 2013, 12:25 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Mark Gaiser.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2013, 12:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First day of week is now following locale's first day of week.
Patch also adds comments (copied from kdepim-runtime) and renames startDay to \
firstDayOfWeek to be more clear what it is.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/calendar.h <span style="color: \
grey">(cc15fcd)</span></li>
<li>src/declarativeimports/calendar/calendar.cpp <span style="color: \
grey">(91d95ac)</span></li>
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(f80d1f9)</span></li>
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(533253f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114099/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic