From kde-panel-devel Mon Nov 25 14:07:50 2013 From: "Martin Klapetek" Date: Mon, 25 Nov 2013 14:07:50 +0000 To: kde-panel-devel Subject: Re: Review Request 114099: Make the calendar applet follow current locale Message-Id: <20131125140750.462.69569 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138538853029275 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7290914961143158781==" --===============7290914961143158781== Content-Type: multipart/alternative; boundary="===============5871676388796720727==" --===============5871676388796720727== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Nov. 25, 2013, 1:02 p.m., Mark Gaiser wrote: > > yeah.. and now this copied part + http://quickgit.kde.org/?p=kdepim-runtime.git&a=shortlog&h=a37e777b73c607f10f8ae87b0950509bab084ced are starting to diverge. > > Please also commit this to the "calendar_components" branch in kdepim-runtime. Done. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114099/#review44389 ----------------------------------------------------------- On Nov. 25, 2013, 12:25 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114099/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2013, 12:25 p.m.) > > > Review request for Plasma and Mark Gaiser. > > > Repository: plasma-framework > > > Description > ------- > > First day of week is now following locale's first day of week. > > Patch also adds comments (copied from kdepim-runtime) and renames startDay to firstDayOfWeek to be more clear what it is. > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.h cc15fcd > src/declarativeimports/calendar/calendar.cpp 91d95ac > src/declarativeimports/calendar/qml/DaysCalendar.qml f80d1f9 > src/declarativeimports/calendar/qml/MonthView.qml 533253f > > Diff: http://git.reviewboard.kde.org/r/114099/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > > --===============5871676388796720727== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114099/

On November 25th, 2013, 1:02 p.m. UTC, Mark Gaiser wrote:

yeah.. and now this copied part + http://quickgit.kde.org/?p=kdepim-runtime.git&a=shortlog&h=a37e777b73c607f10f8ae87b0950509bab084ced are starting to diverge.
Please also commit this to the "calendar_components" branch in kdepim-runtime.
Done.

- Martin


On November 25th, 2013, 12:25 p.m. UTC, Martin Klapetek wrote:

Review request for Plasma and Mark Gaiser.
By Martin Klapetek.

Updated Nov. 25, 2013, 12:25 p.m.

Repository: plasma-framework

Description 

First day of week is now following locale's first day of week.

Patch also adds comments (copied from kdepim-runtime) and renames startDay to firstDayOfWeek to be more clear what it is.

Diffs

  • src/declarativeimports/calendar/calendar.h (cc15fcd)
  • src/declarativeimports/calendar/calendar.cpp (91d95ac)
  • src/declarativeimports/calendar/qml/DaysCalendar.qml (f80d1f9)
  • src/declarativeimports/calendar/qml/MonthView.qml (533253f)

View Diff
--===============5871676388796720727==-- --===============7290914961143158781== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7290914961143158781==--