[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113971: improve screenlocker multiscreen handling
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-11-21 9:59:09
Message-ID: 20131121095909.12091.67290 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 20, 2013, 5:01 p.m., Thomas Lübking wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 238
> > <http://git.reviewboard.kde.org/r/113971/diff/1/?file=215038#file215038line238>
> >
> > this loop is required to make the qml/graphicsscene properly hadnle the forwarded \
> > events.
instead of putting a comment in the reviewboard entry, how about some comments in the \
code explaining why this code is necessary? usually if it needs to be explained, then \
comments in the code are called for.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113971/#review44054
-----------------------------------------------------------
On Nov. 20, 2013, 4:52 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113971/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 4:52 p.m.)
>
>
> Review request for Plasma, Christoph Feck and Martin Gräßlin.
>
>
> Bugs: 311188
> http://bugs.kde.org/show_bug.cgi?id=311188
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> - pass focus to greeter under the mouse
> - share keyboard events
> - let through keyboard events for one hidden locker
> (mouse wakeup case)
> - remove double filtering
>
> @Christoph:
> I meant a real human. A shared responsibility simply means that no one is \
> responsible.
> @Martin:
> I found the dupe and it's assigned to you. Do you feel in charge here or do you \
> know whom to addd?
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeterapp.h 951b1e3
> ksmserver/screenlocker/greeter/greeterapp.cpp bf33945
>
> Diff: http://git.reviewboard.kde.org/r/113971/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113971/">http://git.reviewboard.kde.org/r/113971/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 20th, 2013, 5:01 p.m. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113971/diff/1/?file=215038#file215038line238" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/screenlocker/greeter/greeterapp.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
UnlockApp::desktopResized()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">237</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span> <span class="p">(</span><span \
class="n">QDeclarativeView</span> <span class="o">*</span><span \
class="n">view</span><span class="p">,</span> <span class="n">m_views</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this loop is required to \
make the qml/graphicsscene properly hadnle the forwarded events.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">instead of \
putting a comment in the reviewboard entry, how about some comments in the code \
explaining why this code is necessary? usually if it needs to be explained, then \
comments in the code are called for.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 20th, 2013, 4:52 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Christoph Feck and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2013, 4:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311188">311188</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- pass focus to greeter under the mouse
- share keyboard events
- let through keyboard events for one hidden locker
(mouse wakeup case)
- remove double filtering
@Christoph:
I meant a real human. A shared responsibility simply means that no one is \
responsible.
@Martin:
I found the dupe and it's assigned to you. Do you feel in charge here or do you \
know whom to addd?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(951b1e3)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(bf33945)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113971/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic