'Re: Review Request 113971: improve screenlocker multiscreen handling'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 113971: improve screenlocker multiscreen handling
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2013-11-20 17:22:02
Message-ID: 20131120172202.4493.62041 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113971/#review44057
-----------------------------------------------------------

That's why I used Gänsefüßchen.

Cannot comment on the code.

- Christoph Feck

On Nov. 20, 2013, 4:52 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113971/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 4:52 p.m.)
> 
> 
> Review request for Plasma, Christoph Feck and Martin Gräßlin.
> 
> 
> Bugs: 311188
>     http://bugs.kde.org/show_bug.cgi?id=311188
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> - pass focus to greeter under the mouse
> - share keyboard events
> - let through keyboard events for one hidden locker
>   (mouse wakeup case)
> - remove double filtering
> 
> @Christoph:
> I meant a real human. A shared responsibility simply means that no one is responsible.
> 
> @Martin:
> I found the dupe and it's assigned to you. Do you feel in charge here or do you know whom to addd?
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 951b1e3 
>   ksmserver/screenlocker/greeter/greeterapp.cpp bf33945 
> 
> Diff: http://git.reviewboard.kde.org/r/113971/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113971/">http://git.reviewboard.kde.org/r/113971/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That&#39;s why I used \
Gänsefüßchen.

Cannot comment on the code.</pre>
 <br />

<p>- Christoph Feck</p>

<br />
<p>On November 20th, 2013, 4:52 p.m. UTC, Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Christoph Feck and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Nov. 20, 2013, 4:52 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=311188">311188</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- pass focus to greeter under the mouse
- share keyboard events
- let through keyboard events for one hidden locker
  (mouse wakeup case)
- remove double filtering

@Christoph:
I meant a real human. A shared responsibility simply means that no one is \
responsible.

@Martin:
I found the dupe and it&#39;s assigned to you. Do you feel in charge here or do you \
know whom to addd?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(951b1e3)</span></li>

 <li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(bf33945)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113971/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 