[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists
From:       Sebastian =?ISO-8859-1?Q?K=FCgler?= <sebas () kde ! org>
Date:       2013-09-25 11:10:44
Message-ID: 8075731.lbcFORnRJt () miro ! vizzzion ! net
[Download RAW message or body]

On Wednesday, September 25, 2013 12:40:12 Stephen Kelly wrote:
> Sebastian K=FCgler wrote:
> > CMake-gods, can you confirm the below? (It's inconsistent with my
> > understanding, and how we've done it in the past months, I'd like to ha=
ve
> > a specialist opinion before going around and changing every single
> > CMakeLists.txt in Plasma.)
> =

> Running =

> =

>  git log -S KI18n_LIBRARIES
> =

> shows that I made a mistake and redefined the variable. Fixed now.

That wasn't my question, however. :)

So the verdict is to use variables?

What's the advantage here, all I hear is complaints that errors are harder =
to =

find now.

Cheers,
-- =

sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic