[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112888: Roughly port icon applet to plasma2
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-09-23 11:38:57
Message-ID: 20130923113857.30073.72839 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 23, 2013, 8:28 a.m., Bhushan Shah wrote:
> > File Attachment: files
> > <http://git.reviewboard.kde.org/r/112888/#fcomment110>
> >
> > Show extension or not?
This is a bit of a complicated topic, actually. Quick explanation. Not showing the \
extension bears some security risk. You could have a nasty executable, that uses an \
image as icon. When clicking on it, you're running a programme, rather than opening \
an image. (Now this is not downloaded content, so it's not *that* bad, but we'll \
probably still need to take this into account.
Have you looked at the original Icon widget what it does here?
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40498
-----------------------------------------------------------
On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2013, 8:26 a.m.)
>
>
> Review request for Plasma, Marco Martin and Sebastian Kügler.
>
>
> Description
> -------
>
> Port Icon applet to plasma2
>
> Some issues..
>
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
>
>
> Diffs
> -----
>
> plasma/generic/applets/CMakeLists.txt 4ace449
> plasma/generic/applets/icon/CMakeLists.txt 1094666
> plasma/generic/applets/icon/icon.h 45fa07c
> plasma/generic/applets/icon/icon.cpp 8288850
> plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION
> plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION
> plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION
> plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd
> plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION
> plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION
> plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION
> plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION
> plasma/generic/applets/icon/plugin/qmldir PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
>
>
> Testing
> -------
>
> 1) Compiles
> 2) Installs
> 3) Loads
>
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor text \
> because folder handling is not added yet.
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
>
>
> File Attachments
> ----------------
>
> icons in panel
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
>
>
> Thanks,
>
> Bhushan Shah
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112888/">http://git.reviewboard.kde.org/r/112888/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 23rd, 2013, 8:28 a.m. UTC, <b>Bhushan \
Shah</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png" \
style="color: black; font-weight: bold; font-size: 9pt;">files</a></td> </tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Show extension or \
not?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a \
bit of a complicated topic, actually. Quick explanation. Not showing the extension \
bears some security risk. You could have a nasty executable, that uses an image as \
icon. When clicking on it, you're running a programme, rather than opening an \
image. (Now this is not downloaded content, so it's not *that* bad, but we'll \
probably still need to take this into account.
Have you looked at the original Icon widget what it does here?</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On September 23rd, 2013, 8:26 a.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Marco Martin and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 8:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port Icon applet to plasma2
Some issues..
-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Compiles 2) Installs
3) Loads
-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text \
because folder handling is not added yet.
4) Opens URL - Clicking on the icon applet opens url with kfmclient</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/CMakeLists.txt <span style="color: \
grey">(4ace449)</span></li>
<li>plasma/generic/applets/icon/CMakeLists.txt <span style="color: \
grey">(1094666)</span></li>
<li>plasma/generic/applets/icon/icon.h <span style="color: \
grey">(45fa07c)</span></li>
<li>plasma/generic/applets/icon/icon.cpp <span style="color: \
grey">(8288850)</span></li>
<li>plasma/generic/applets/icon/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plasma-applet-icon.desktop <span style="color: \
grey">(8275ddd)</span></li>
<li>plasma/generic/applets/icon/plugin/icon_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plugin/icon_p.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plugin/iconplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plugin/iconplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plugin/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112888/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png">icons \
in panel</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png">icons \
as launcher</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png">files</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png">folders</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic