'Re: Review Request 112888: Roughly port icon applet to plasma2'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112888: Roughly port icon applet to plasma2
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2013-09-23 9:47:29
Message-ID: 20130923094729.13643.73459 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40507
-----------------------------------------------------------

plasma/generic/applets/icon/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/112888/#comment29818>

    For license, we prefer the GPL with KDE e.V. exception. I'll leave this up to you \
whether you think this is OK for this code or not. (As long as it's GPL or LGPL (or \
more liberal), we'll accept it.)  
    The preferred one would be the second option here:
    http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header

plasma/generic/applets/icon/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/112888/#comment29819>

    Use 16 here, I'd say. 1x1 icons don't make sense.

plasma/generic/applets/icon/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/112888/#comment29821>

    This will not work well for iconswithlongnamebutwithoutspacesinthename.extension. \
:)

plasma/generic/applets/icon/package/metadata.desktop
<http://git.reviewboard.kde.org/r/112888/#comment29817>

    This should probably be 32,32 or 48,48. 100 is not among the standard icon sizes.

plasma/generic/applets/icon/plugin/icon_p.h
<http://git.reviewboard.kde.org/r/112888/#comment29822>

    Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). That would \
seem more declarative.  
    This would also make the "remote" case easier, when you have to stat a remote \
file asynchronously and only know details after the network request.

plasma/generic/applets/icon/plugin/icon_p.cpp
<http://git.reviewboard.kde.org/r/112888/#comment29829>

    m_ is for members

plasma/generic/applets/icon/plugin/icon_p.cpp
<http://git.reviewboard.kde.org/r/112888/#comment29824>

    url.fileName(); is not enough here?

plasma/generic/applets/icon/plugin/icon_p.cpp
<http://git.reviewboard.kde.org/r/112888/#comment29828>

    m_ is for members, use icon or iconName here.

plasma/generic/applets/icon/plugin/icon_p.cpp
<http://git.reviewboard.kde.org/r/112888/#comment29823>

    trailing whitespace

plasma/generic/applets/icon/plugin/icon_p.cpp
<http://git.reviewboard.kde.org/r/112888/#comment29825>

    } else ...

    (no new line)

plasma/generic/applets/icon/plugin/icon_p.cpp
<http://git.reviewboard.kde.org/r/112888/#comment29827>

    m_ prefix is used for member variables. Rename it to genericName for example.

plasma/generic/applets/icon/plugin/icon_p.cpp
<http://git.reviewboard.kde.org/r/112888/#comment29826>

    no new line

Definitely going in the right direction. Let's get a few issues I've pointed out \
inside fixed, then merge it into frameworks-scratch and finish it up there.

- Sebastian Kügler

On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -----
> 
> plasma/generic/applets/CMakeLists.txt 4ace449 
> plasma/generic/applets/icon/CMakeLists.txt 1094666 
> plasma/generic/applets/icon/icon.h 45fa07c 
> plasma/generic/applets/icon/icon.cpp 8288850 
> plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
> plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
> plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
> plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
> plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
> plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
> plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
> plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
> plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> -------
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor text \
> because folder handling is not added yet. 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> ----------------
> 
> icons in panel
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112888/">http://git.reviewboard.kde.org/r/112888/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191265#file191265line17" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/package/contents/ui/main.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">17</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> */</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For \
license, we prefer the GPL with KDE e.V. exception. I&#39;ll leave this up to you \
whether you think this is OK for this code or not. (As long as it&#39;s GPL or LGPL \
(or more liberal), we&#39;ll accept it.)

The preferred one would be the second option here:
http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191265#file191265line31" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/package/contents/ui/main.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">minimumWidth:</span> <span class="nx">formFactor</span> <span \
class="o">==</span> <span class="nx">PlasmaCore</span><span class="p">.</span><span \
class="nx">Types</span><span class="p">.</span><span class="nx">Horizontal</span> \
<span class="o">?</span> <span class="k">height :</span> <span \
class="mi">1</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use 16 \
here, I&#39;d say. 1x1 icons don&#39;t make sense.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191265#file191265line67" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/package/contents/ui/main.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">67</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">wrapMode:</span> <span class="nx">Text</span><span class="p">.</span><span \
class="nx">WordWrap</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will \
not work well for iconswithlongnamebutwithoutspacesinthename.extension. :)</pre> \
</div> <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191266#file191266line169" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/package/metadata.desktop</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">169</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">X-Plasma-DefaultSize=100,100</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
probably be 32,32 or 48,48. 100 is not among the standard icon sizes.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191268#file191268line31" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/plugin/icon_p.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">Q_INVOKABLE</span> <span class="n">QString</span> <span \
class="n">getGenericName</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QUrl</span><span class="o">&amp;</span> <span \
class="n">url</span><span class="p">)</span> <span class="k">const</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why \
Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). That would seem \
more declarative.

This would also make the &quot;remote&quot; case easier, when you have to stat a \
remote file asynchronously and only know details after the network request.</pre> \
</div> <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line31" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/plugin/icon_p.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QString</span> <span class="n">m_name</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">m_ is for \
members</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line39" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/plugin/icon_p.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">39</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="tb">	</span><span class="n">m_name</span> <span \
class="o">=</span> <span class="n">QFileInfo</span><span class="p">(</span><span \
class="n">url</span><span class="p">.</span><span class="n">toLocalFile</span><span \
class="p">()).</span><span class="n">fileName</span><span \
class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">url.fileName(); is not enough here?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line51" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/plugin/icon_p.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QString</span> <span class="n">m_icon</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">m_ is for \
members, use icon or iconName here.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line58" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/plugin/icon_p.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">58</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span>    <span class="n">m_icon</span> <span class="o">=</span> <span \
class="n">f</span><span class="p">.</span><span class="n">readIcon</span><span \
class="p">();</span><span class="ew"><span class="tb">	</span>    </span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">trailing \
whitespace</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line60" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/plugin/icon_p.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">60</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="k">else</span> <span class="k">if</span> <span \
class="p">(</span><span class="o">!</span><span class="n">fi</span><span \
class="p">.</span><span class="n">isDir</span><span class="p">())</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">} else ...

(no new line)</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line69" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/plugin/icon_p.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">69</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QString</span> <span class="n">m_generic</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">m_ prefix \
is used for member variables. Rename it to genericName for example.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line76" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/icon/plugin/icon_p.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">76</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no new \
line</pre> </div>
<br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Definitely going in the \
right direction. Let&#39;s get a few issues I&#39;ve pointed out inside fixed, then \
merge it into frameworks-scratch and finish it up there.</pre>

<p>- Sebastian</p>

<br />
<p>On September 23rd, 2013, 8:26 a.m. UTC, Bhushan Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Marco Martin and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated Sept. 23, 2013, 8:26 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port Icon applet to plasma2

Some issues..

-&gt; Can be resized to 1x1.
-&gt; Still doesn&#39;t work for folder, and external URLs.
-&gt; Configuration dialog</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Compiles 2) Installs
3) Loads

-&gt; Dropping application icon from KickOff - creates icon
-&gt; Dropping files from Dolphin, both executable and normal files - creates icon
-&gt; Dropping folder from Dolphin - creates icon applet but neither icon nor text \
because folder handling is not added yet.

4) Opens URL - Clicking on the icon applet opens url with kfmclient</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/CMakeLists.txt <span style="color: \
grey">(4ace449)</span></li>

 <li>plasma/generic/applets/icon/CMakeLists.txt <span style="color: \
grey">(1094666)</span></li>

 <li>plasma/generic/applets/icon/icon.h <span style="color: \
grey">(45fa07c)</span></li>

 <li>plasma/generic/applets/icon/icon.cpp <span style="color: \
grey">(8288850)</span></li>

 <li>plasma/generic/applets/icon/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/icon/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/icon/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/icon/plasma-applet-icon.desktop <span style="color: \
grey">(8275ddd)</span></li>

 <li>plasma/generic/applets/icon/plugin/icon_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/icon/plugin/icon_p.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/icon/plugin/iconplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/icon/plugin/iconplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/icon/plugin/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112888/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png">icons \
in panel</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png">icons \
as launcher</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png">files</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png">folders</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 