[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devi
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-09-19 14:57:29
Message-ID: 20130919145729.6970.53047 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112812/#review40353
-----------------------------------------------------------
Ship it!
Looks good, thanks for the patch, just fix the whitespace, then it's good to go. Do \
you have a Git account? In that case, please push to KDE/4.11, master and \
frameworks-scratch branches.
plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml
<http://git.reviewboard.kde.org/r/112812/#comment29774>
one space to much to line up with the previous line, same for other added lines.
- Sebastian Kügler
On Sept. 19, 2013, 11:44 a.m., Benedikt Gollatz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112812/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2013, 11:44 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Use type description sort order in the devicenotifier applet when non-removable \
> devices are configured to be displayed. This avoids apparently random sort order \
> (by device engine population timestamp) and unneccessary ListView sections. The \
> problem becomes apparent if other types of devices besides simple storage volumes \
> are configured in /etc/fstab, like for example network mounts.
> Fixes bug #324459.
>
>
> This addresses bug 324459.
> http://bugs.kde.org/show_bug.cgi?id=324459
>
>
> Diffs
> -----
>
> plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
> 9b6132e95bf12cac726699fd40850a6b1d3513b6
> Diff: http://git.reviewboard.kde.org/r/112812/diff/
>
>
> Testing
> -------
>
> Works for me using KDE 4.10.5 packaged with Fedora 19.
>
>
> Thanks,
>
> Benedikt Gollatz
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112812/">http://git.reviewboard.kde.org/r/112812/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, thanks for \
the patch, just fix the whitespace, then it's good to go. Do you have a Git \
account? In that case, please push to KDE/4.11, master and frameworks-scratch \
branches.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112812/diff/1/?file=190512#file190512line132" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">132</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">filterModel</span><span class="p">.</span><span \
class="nx">sortRole</span> <span class="o">=</span> <span class="s2">"Type \
Description"</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">one space \
to much to line up with the previous line, same for other added lines.</pre> </div>
<br />
<p>- Sebastian</p>
<br />
<p>On September 19th, 2013, 11:44 a.m. UTC, Benedikt Gollatz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Benedikt Gollatz.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2013, 11:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use type description sort order in the devicenotifier applet when \
non-removable devices are configured to be displayed. This avoids apparently random \
sort order (by device engine population timestamp) and unneccessary ListView \
sections. The problem becomes apparent if other types of devices besides simple \
storage volumes are configured in /etc/fstab, like for example network mounts.
Fixes bug #324459.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me using KDE 4.10.5 packaged with Fedora 19.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=324459">324459</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
<span style="color: grey">(9b6132e95bf12cac726699fd40850a6b1d3513b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112812/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic