'Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devi'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devi
From:       "Benedikt Gollatz" <benedikt () gollatz ! net>
Date:       2013-09-19 11:44:31
Message-ID: 20130919114431.12709.78555 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112812/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 11:44 a.m.)

Review request for Plasma.

Description
-------

Use type description sort order in the devicenotifier applet when non-removable \
devices are configured to be displayed. This avoids apparently random sort order (by \
device engine population timestamp) and unneccessary ListView sections. The problem \
becomes apparent if other types of devices besides simple storage volumes are \
configured in /etc/fstab, like for example network mounts.

Fixes bug #324459.

This addresses bug 324459.
    http://bugs.kde.org/show_bug.cgi?id=324459

Diffs
-----

  plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
9b6132e95bf12cac726699fd40850a6b1d3513b6 

Diff: http://git.reviewboard.kde.org/r/112812/diff/

Testing
-------

Works for me using KDE 4.10.5 packaged with Fedora 19.

Thanks,

Benedikt Gollatz

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112812/">http://git.reviewboard.kde.org/r/112812/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Benedikt Gollatz.</div>

<p style="color: grey;"><i>Updated Sept. 19, 2013, 11:44 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use type description sort order in the devicenotifier applet when \
non-removable devices are configured to be displayed. This avoids apparently random \
sort order (by device engine population timestamp) and unneccessary ListView \
sections. The problem becomes apparent if other types of devices besides simple \
storage volumes are configured in /etc/fstab, like for example network mounts.

Fixes bug #324459.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me using KDE 4.10.5 packaged with Fedora 19.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=324459">324459</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
<span style="color: grey">(9b6132e95bf12cac726699fd40850a6b1d3513b6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112812/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 