'Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly
From:       "Paul Rohrbach" <p.b.r () gmx ! net>
Date:       2013-09-11 17:48:16
Message-ID: 20130911174816.3744.94635 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112674/
-----------------------------------------------------------

(Updated Sept. 11, 2013, 5:48 p.m.)

Review request for Plasma.

Summary (updated)
-----------------

Bugfix: Make the calculator applet calculate correctly

Description
-------

This patch should solve bug 313869.

The bug reported this behaviour: if you press something like 'a+b+c=', the result \
would be incorrect because the calculator plasmoid wrongly resets the calculator when \
pressing 'c'. The intended behaviour is that the calculation is cleared when pressing \
a number after pressing '='.

This patch adds a variable to determine this situation correctly.

This addresses bug 313869.
    http://bugs.kde.org/show_bug.cgi?id=313869

Diffs (updated)
-----

  applets/calculator/package/contents/ui/calculator.qml b4f0654 

Diff: http://git.reviewboard.kde.org/r/112674/diff/

Testing
-------

It works for me in Plasmate.

Thanks,

Paul Rohrbach

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112674/">http://git.reviewboard.kde.org/r/112674/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Paul Rohrbach.</div>

<p style="color: grey;"><i>Updated Sept. 11, 2013, 5:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bugfix: Make the calculator applet calculate correctly</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch should solve bug 313869.

The bug reported this behaviour: if you press something like &#39;a+b+c=&#39;, the \
result would be incorrect because the calculator plasmoid wrongly resets the \
calculator when pressing &#39;c&#39;. The intended behaviour is that the calculation \
is cleared when pressing a number after pressing &#39;=&#39;.

This patch adds a variable to determine this situation correctly.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works for me in Plasmate.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=313869">313869</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/calculator/package/contents/ui/calculator.qml <span style="color: \
grey">(b4f0654)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112674/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 