[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112674: Bugfix: Make the calculator applet calculate correct
From: "Paul Rohrbach" <p.b.r () gmx ! net>
Date: 2013-09-11 17:43:15
Message-ID: 20130911174315.3042.22543 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 11, 2013, 5:28 p.m., Sebastian Kügler wrote:
> > applets/calculator/package/contents/ui/calculator.qml, line 41
> > <http://git.reviewboard.kde.org/r/112674/diff/1/?file=188980#file188980line41>
> >
> > Why is this change needed (operator initialized to undefined)?
This should not be part of the patch, i didn't saw it when uploading the patch... I \
changed the line, because it created a warning for me (Unable to assign [undefined] \
to QString operator) and I wanted to test what the problem was. I changed it back in \
the second diff.
> On Sept. 11, 2013, 5:28 p.m., Sebastian Kügler wrote:
> > applets/calculator/package/contents/ui/calculator.qml, line 111
> > <http://git.reviewboard.kde.org/r/112674/diff/1/?file=188980#file188980line111>
> >
> > space after if and before (
Oops, sorry for that. It is also corrected in the second diff.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112674/#review39846
-----------------------------------------------------------
On Sept. 11, 2013, 5 p.m., Paul Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112674/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2013, 5 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch should solve bug 313869.
>
> The bug reported this behaviour: if you press something like 'a+b+c=', the result \
> would be incorrect because the calculator plasmoid wrongly resets the calculator \
> when pressing 'c'. The intended behaviour is that the calculation is cleared when \
> pressing a number after pressing '='.
> This patch adds a variable to determine this situation correctly.
>
>
> This addresses bug 313869.
> http://bugs.kde.org/show_bug.cgi?id=313869
>
>
> Diffs
> -----
>
> applets/calculator/package/contents/ui/calculator.qml b4f0654
>
> Diff: http://git.reviewboard.kde.org/r/112674/diff/
>
>
> Testing
> -------
>
> It works for me in Plasmate.
>
>
> Thanks,
>
> Paul Rohrbach
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112674/">http://git.reviewboard.kde.org/r/112674/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 11th, 2013, 5:28 p.m. UTC, \
<b>Sebastian Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112674/diff/1/?file=188980#file188980line41" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/calculator/package/contents/ui/calculator.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">41</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="nx">string</span> <span \
class="k">operator:</span> <span class="s2">""</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this change \
needed (operator initialized to undefined)?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
not be part of the patch, i didn't saw it when uploading the patch... I changed \
the line, because it created a warning for me (Unable to assign [undefined] to \
QString operator) and I wanted to test what the problem was. I changed it back in the \
second diff.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 11th, 2013, 5:28 p.m. UTC, \
<b>Sebastian Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112674/diff/1/?file=188980#file188980line111" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/calculator/package/contents/ui/calculator.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">111</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span><span class="nx">showingResult</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">space after if and \
before (</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops, sorry \
for that. It is also corrected in the second diff.</pre> <br />
<p>- Paul</p>
<br />
<p>On September 11th, 2013, 5 p.m. UTC, Paul Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Paul Rohrbach.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2013, 5 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch should solve bug 313869.
The bug reported this behaviour: if you press something like 'a+b+c=', the \
result would be incorrect because the calculator plasmoid wrongly resets the \
calculator when pressing 'c'. The intended behaviour is that the calculation \
is cleared when pressing a number after pressing '='.
This patch adds a variable to determine this situation correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works for me in Plasmate.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313869">313869</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/calculator/package/contents/ui/calculator.qml <span style="color: \
grey">(b4f0654)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112674/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic