'Re: Review Request 112360: Enable mouse DataEngine on KF5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112360: Enable mouse DataEngine on KF5
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2013-08-31 6:39:35
Message-ID: 20130831063935.9149.4943 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112360/#review38978
-----------------------------------------------------------

Note: the CursorNotificationHandler has a method x11Event which means this needs \
porting to XCB and QAbstractNativeEventFilter. If you have any questions about that, \
just ping me on IRC on Monday.

- Martin Gräßlin

On Aug. 29, 2013, 3:47 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112360/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 3:47 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Enabling mouse DataEngine on KF5. Disabling cursor notification handler support for \
> *now*. Some wired compilation errors. 
> 
> Diffs
> -----
> 
> plasma/generic/dataengines/CMakeLists.txt f08b3b0 
> plasma/generic/dataengines/mouse/CMakeLists.txt 86d7acc 
> plasma/generic/dataengines/mouse/mouseengine.h d55565d 
> plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 
> 
> Diff: http://git.reviewboard.kde.org/r/112360/diff/
> 
> 
> Testing
> -------
> 
> Compiles - check without cursor notification handler
> Links - check
> Installs - check
> Works - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112360/">http://git.reviewboard.kde.org/r/112360/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note: the \
CursorNotificationHandler has a method x11Event which means this needs porting to XCB \
and QAbstractNativeEventFilter. If you have any questions about that, just ping me on \
IRC on Monday.</pre>  <br />

<p>- Martin</p>

<br />
<p>On August 29th, 2013, 3:47 p.m. CEST, Bhushan Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated Aug. 29, 2013, 3:47 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Enabling mouse DataEngine on KF5. Disabling cursor notification handler \
support for *now*. Some wired compilation errors.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles - check without cursor notification handler Links - check
Installs - check
Works - check</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/dataengines/CMakeLists.txt <span style="color: \
grey">(f08b3b0)</span></li>

 <li>plasma/generic/dataengines/mouse/CMakeLists.txt <span style="color: \
grey">(86d7acc)</span></li>

 <li>plasma/generic/dataengines/mouse/mouseengine.h <span style="color: \
grey">(d55565d)</span></li>

 <li>plasma/generic/dataengines/mouse/mouseengine.cpp <span style="color: \
grey">(19a7fb7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112360/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 