--===============1298571331296229770== Content-Type: multipart/alternative; boundary="===============4416347511416186950==" --===============4416347511416186950== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112360/#review38978 ----------------------------------------------------------- Note: the CursorNotificationHandler has a method x11Event which means this needs porting to XCB and QAbstractNativeEventFilter. If you have any questions about that, just ping me on IRC on Monday. - Martin Gräßlin On Aug. 29, 2013, 3:47 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112360/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2013, 3:47 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Description > ------- > > Enabling mouse DataEngine on KF5. Disabling cursor notification handler support for *now*. Some wired compilation errors. > > > Diffs > ----- > > plasma/generic/dataengines/CMakeLists.txt f08b3b0 > plasma/generic/dataengines/mouse/CMakeLists.txt 86d7acc > plasma/generic/dataengines/mouse/mouseengine.h d55565d > plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 > > Diff: http://git.reviewboard.kde.org/r/112360/diff/ > > > Testing > ------- > > Compiles - check without cursor notification handler > Links - check > Installs - check > Works - check > > > Thanks, > > Bhushan Shah > > --===============4416347511416186950== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112360/ 

Note: the CursorNotificationHandler has a method x11Event which means this needs porting to XCB and QAbstractNativeEventFilter. If you have any questions about that, just ping me on IRC on Monday.

- Martin


On August 29th, 2013, 3:47 p.m. CEST, Bhushan Shah wrote:

Review request for Plasma and Sebastian Kügler.
By Bhushan Shah.

Updated Aug. 29, 2013, 3:47 p.m.

Description 

Enabling mouse DataEngine on KF5. Disabling cursor notification handler support for *now*. Some wired compilation errors.

Testing 

Compiles - check without cursor notification handler
Links - check
Installs - check
Works - check

Diffs

  • plasma/generic/dataengines/CMakeLists.txt (f08b3b0)
  • plasma/generic/dataengines/mouse/CMakeLists.txt (86d7acc)
  • plasma/generic/dataengines/mouse/mouseengine.h (d55565d)
  • plasma/generic/dataengines/mouse/mouseengine.cpp (19a7fb7)

View Diff
--===============4416347511416186950==-- --===============1298571331296229770== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1298571331296229770==--